Add -C option to commit patches immediately

Review Request #6122 — Created July 21, 2014 and submitted

Information

RBTools
master
2a12a09...

Reviewers

It is very useful to be able to script a series of patch
applications all at once (such as when reviewing a patch series).
In these cases, it is useful to be able to accept the default
commit message for each patch.

Patched my local RBTools installation with these changes and pulled a patch into my working tree using the -C option. It applied with the default commit as expected.

Description From Last Updated

Col: 80 E501 line too long (83 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (83 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (83 > 79 characters)

reviewbotreviewbot

I think I'd prefer to have this be called run_editor and have it set to True when -c is passed.

daviddavid

The long option should probably be --commit-no-edit

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/patch.py
        rbtools/clients/__init__.py
        rbtools/clients/mercurial.py
        rbtools/clients/git.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/patch.py
        rbtools/clients/__init__.py
        rbtools/clients/mercurial.py
        rbtools/clients/git.py
    
    
  2. rbtools/clients/__init__.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (83 > 79 characters)
    
  3. rbtools/clients/git.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (83 > 79 characters)
    
  4. rbtools/clients/mercurial.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (83 > 79 characters)
    
  5. 
      
sgallagh
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/patch.py
        rbtools/clients/__init__.py
        rbtools/clients/mercurial.py
        rbtools/clients/git.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/patch.py
        rbtools/clients/__init__.py
        rbtools/clients/mercurial.py
        rbtools/clients/git.py
    
    
  2. 
      
david
  1. 
      
  2. rbtools/clients/__init__.py (Diff revision 2)
     
     

    I think I'd prefer to have this be called run_editor and have it set to True when -c is passed.

  3. rbtools/commands/patch.py (Diff revision 2)
     
     
     

    The long option should probably be --commit-no-edit

  4. 
      
sgallagh
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/patch.py
        rbtools/clients/__init__.py
        rbtools/clients/mercurial.py
        rbtools/clients/git.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/patch.py
        rbtools/clients/__init__.py
        rbtools/clients/mercurial.py
        rbtools/clients/git.py
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
sgallagh
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.6.x (675ebe0)
Loading...