Summary

Add -C option to commit patches immediately

Review Request #6122 — Created July 21, 2014 and submitted July 30, 2014, 2:47 p.m.

Information

Owner

sgallagh

Repository

RBTools

Branch

master

Bugs

Depends On

Commit

2a12a09...

Reviewers

Groups

rbtools

People

Description

It is very useful to be able to script a series of patch
applications all at once (such as when reviewing a patch series).
In these cases, it is useful to be able to accept the default
commit message for each patch.

Testing Done

Patched my local RBTools installation with these changes and pulled a patch into my working tree using the -C option. It applied with the default commit as expected.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	July 21, 2014, 2 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	July 21, 2014, 2 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	July 21, 2014, 2 p.m.
I think I'd prefer to have this be called run_editor and have it set to True when -c is passed.	david	July 30, 2014, 2:47 p.m.
The long option should probably be --commit-no-edit	david	July 30, 2014, 2:47 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/commands/patch.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/git.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/patch.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/git.py

rbtools/clients/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
rbtools/clients/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
rbtools/clients/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```

Change Summary:

Fixed long lines detected by Review Bot.

Commit:

bd1ca9523da359dfb334c07301559e34bc10e762

28771179bee53ba94ab9bfb1e957ef6b15fbf764

Diff:

Revision 2 (+24 -7)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/git.py
	rbtools/clients/mercurial.py
	rbtools/commands/patch.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/patch.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/git.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/patch.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/git.py

rbtools/clients/__init__.py (Diff revision 2)

The issue has been resolved. Show all issues

I think I'd prefer to have this be called run_editor and have it set to True when -c is passed.

rbtools/commands/patch.py (Diff revision 2)
The issue has been resolved. Show all issues
```
The long option should probably be --commit-no-edit
```

Commit:

28771179bee53ba94ab9bfb1e957ef6b15fbf764

2a12a094f38d94da21d700e276ccd0bd028e685d

Diff:

Revision 3 (+25 -7)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/git.py
	rbtools/clients/mercurial.py
	rbtools/commands/patch.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/patch.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/git.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/patch.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/git.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.6.x (675ebe0)