Fix error handling in "Upload Diff" and "Add File" dialogs.
Review Request #6112 — Created July 17, 2014 and submitted
These dialogs are still driven by some pretty ancient javascript code in
common.js. All the backend code had been changed to use the new resource
models, but the error handling callback hadn't been updated for the new
attributes. The result of this was that instead of seeing an error in the form,
users would just see an endless "Loading..." spinner.
- Tried to upload a .png file instead of a diff and saw the error shown next to
the 'diff' field. - Tried to submit the 'Add File' form without selecting a file and saw the
error shown next to the 'path' field.
-
-
reviewboard/static/rb/js/common.js (Diff revision 1) While here, can we remove the
// errorcomment? It's not useful at all. -
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+5 -11) |
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/common.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/common.js