Add django-reset to dependencies.

Review Request #6104 — Created July 14, 2014 and submitted

Information

Review Board
release-2.0.x
ba606ad...

Reviewers

We still use 'manage.py reset' in a few cases, and 'manage.py flush' is not an
equivalent replacement. This change pulls in the 'django-reset' package as a
dependency, which forward-ports this management command.

Ran ./reviewboard/manage.py --help and saw the reset commands.

Description From Last Updated

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot

'PIPELINE_CSS' imported but unused

reviewbotreviewbot

'PIPELINE_JS' imported but unused

reviewbotreviewbot

'django_reset' imported but unused

reviewbotreviewbot

This needs to be removed.

chipx86chipx86

'django_reset' imported but unused

reviewbotreviewbot

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot

'PIPELINE_CSS' imported but unused

reviewbotreviewbot

'PIPELINE_JS' imported but unused

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        setup.py
        reviewboard/settings.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        setup.py
        reviewboard/settings.py
    
    
  2. reviewboard/settings.py (Diff revision 1)
     
     
     'from settings_local import *' used; unable to detect undefined names
    
  3. reviewboard/settings.py (Diff revision 1)
     
     
     'PIPELINE_CSS' imported but unused
    
  4. reviewboard/settings.py (Diff revision 1)
     
     
     'PIPELINE_JS' imported but unused
    
  5. 
      
chipx86
  1. We only use this for development, right? I don't think we should require it for the package itself. How about trying to import it in settings, and if it exists, adding it to INSTALLED_APPS?

    (Of course, we can just do this ourselves in our own settings_local with RB_EXTRA_APPS.)

    There's really a handful of modules we only use for development that we should make easier to install. Maybe in prepare-dev.py, or some new setup.py target of some sort.

    1. It's also used in the 'loaddb' command. I'm not sure if we consider that "only for development" or not.

    2. Oh okay. Fair enough I suppose.

      We may want to look into removing dumpdb/loaddb, now that dumpdata/loaddata no longer has the memory issues it used to have.

    3. Okay, thinking on this more, I think the use-cases are too rare to justify a hard dependency. I'd suggest we have loaddb try to import, tell the user what to type if they don't have it, and leave it at that.

      We have so many dependencies as it is, and this is one that doesn't offer any real benefit to almost any of our users. It especially makes life harder for packagers and those who can't easy_install from within their network.

  2. 
      
david
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/admin/management/commands/loaddb.py
        reviewboard/settings.py
    
    Ignored Files:
        docs/codebase/unit-tests/fixtures.rst
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/admin/management/commands/loaddb.py
        reviewboard/settings.py
    
    Ignored Files:
        docs/codebase/unit-tests/fixtures.rst
    
    
  2.  'django_reset' imported but unused
    
  3. reviewboard/settings.py (Diff revision 2)
     
     
     'django_reset' imported but unused
    
  4. reviewboard/settings.py (Diff revision 2)
     
     
     'from settings_local import *' used; unable to detect undefined names
    
  5. reviewboard/settings.py (Diff revision 2)
     
     
     'PIPELINE_CSS' imported but unused
    
  6. reviewboard/settings.py (Diff revision 2)
     
     
     'PIPELINE_JS' imported but unused
    
  7. 
      
chipx86
  1. 
      
  2. reviewboard/settings.py (Diff revision 2)
     
     

    This needs to be removed.

  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (0640527)
Loading...