Summary

Add django-reset to dependencies.

Review Request #6104 — Created July 14, 2014 and submitted July 14, 2014, 4:38 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

ba606ad...

Reviewers

Groups

reviewboard

People

Description

We still use 'manage.py reset' in a few cases, and 'manage.py flush' is not an

equivalent replacement. This change pulls in the 'django-reset' package as a

dependency, which forward-ports this management command.

Testing Done

Ran ./reviewboard/manage.py --help and saw the reset commands.

Issues

Description	From	Last Updated
'from settings_local import *' used; unable to detect undefined names	reviewbot	July 14, 2014, 3:54 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	July 14, 2014, 3:54 p.m.
'PIPELINE_JS' imported but unused	reviewbot	July 14, 2014, 3:54 p.m.
'django_reset' imported but unused	reviewbot	July 14, 2014, 4:36 p.m.
This needs to be removed.	chipx86	July 14, 2014, 4:38 p.m.
'django_reset' imported but unused	reviewbot	July 14, 2014, 4:36 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	July 14, 2014, 4:36 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	July 14, 2014, 4:36 p.m.
'PIPELINE_JS' imported but unused	reviewbot	July 14, 2014, 4:36 p.m.

Tool: Pyflakes
Processed Files:
    setup.py
    reviewboard/settings.py



Tool: PEP8 Style Checker
Processed Files:
    setup.py
    reviewboard/settings.py

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

We only use this for development, right? I don't think we should require it for the package itself. How about trying to import it in settings, and if it exists, adding it to INSTALLED_APPS?
(Of course, we can just do this ourselves in our own settings_local with RB_EXTRA_APPS.)
There's really a handful of modules we only use for development that we should make easier to install. Maybe in prepare-dev.py, or some new setup.py target of some sort.

david July 14, 2014, 4:13 p.m.

It's also used in the 'loaddb' command. I'm not sure if we consider that "only for development" or not.

chipx86 July 14, 2014, 4:13 p.m.

Oh okay. Fair enough I suppose.

We may want to look into removing dumpdb/loaddb, now that dumpdata/loaddata no longer has the memory issues it used to have.

chipx86 July 14, 2014, 4:29 p.m.

Okay, thinking on this more, I think the use-cases are too rare to justify a hard dependency. I'd suggest we have loaddb try to import, tell the user what to type if they don't have it, and leave it at that.

We have so many dependencies as it is, and this is one that doesn't offer any real benefit to almost any of our users. It especially makes life harder for packagers and those who can't easy_install from within their network.

Commit:

5f2aa35623050e84a5227d1279fcb527f4af668b

ba606addc8ab7bbe509ad939cb0e0d39bf1765df

Diff:

Revision 2 (+18 -1)

Show changes

	docs/codebase/unit-tests/fixtures.rst
	reviewboard/settings.py
	reviewboard/admin/management/commands/loaddb.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/management/commands/loaddb.py
    reviewboard/settings.py

Ignored Files:
    docs/codebase/unit-tests/fixtures.rst



Tool: Pyflakes
Processed Files:
    reviewboard/admin/management/commands/loaddb.py
    reviewboard/settings.py

Ignored Files:
    docs/codebase/unit-tests/fixtures.rst

reviewboard/admin/management/commands/loaddb.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Ship it!

reviewboard/settings.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This needs to be removed.
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (0640527)

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 2)