Allow users to log in using their e-mail address.
Review Request #6103 — Created July 14, 2014 and submitted
One thing that sometimes happens is that users will try to log in using their
e-mail address instead of their username, and then get confused when it doesn't
work. This is exacerbated by the fact that our sessions last a long time, so
it's often been a very long time since users had to log in.This change makes it so that if a user logs in, and the username isn't found,
it will try to look up their user by e-mail address.
Logged in to my devserver using both my username and my e-mail address.
| Description | From | Last Updated |
|---|---|---|
|
Can we combine these into one query? Get an object (or objects) that match at least one of these, and … |
 chipx86
|
-
I was tempted to do this as well, after the recent attempt.
What happens if two users have the same e-mail address? We should probably disallow login in that case. Otherwise, the wrong username will be used internally, the password won't match, and the user will be very confused.
-
reviewboard/accounts/forms/auth.py (Diff revision 1) Can we combine these into one query? Get an object (or objects) that match at least one of these, and figure things out from there?
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+26 -1) |
Tool: PEP8 Style Checker Processed Files: reviewboard/accounts/forms/auth.py reviewboard/accounts/urls.py Tool: Pyflakes Processed Files: reviewboard/accounts/forms/auth.py reviewboard/accounts/urls.py