-
-
review_together/review_together/forms.py (Diff revision 1) Col: 1 E302 expected 2 blank lines, found 1
-
review_together/review_together/views.py (Diff revision 1) Col: 1 E302 expected 2 blank lines, found 1
User is able to specify their own hub in extension configurations.
Review Request #6102 — Created July 13, 2014 and submitted
User is able to specify their own hub in extension configurations.
A hub server was run locally. Its URL was used in the extension configuration. The local server was used successfully to support the extension.
To test the hub used is actually the one indicated:
Launch the chat app while the local server is not on. The chat should still launch but using the "add friend" link on another browser should not connect the two clients.To test the default hub is used when no hub is specified, remove any input in the extension configuration screen. Launch the chat app and using another browser connect to the first client with the "Add friend" link. The clients should be able to see each other's mouse movements.
| Description | From | Last Updated |
|---|---|---|
|
Col: 1 E302 expected 2 blank lines, found 1 |
 reviewbot
|
|
|
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
This isn't used anymore (since 'urlpatterns' is redefined below). |
 david
|
|
|
Col: 5 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 2 W292 no newline at end of file |
reviewbot
|
|
|
'settings' imported but unused |
reviewbot
|
|
|
'patterns' imported but unused |
reviewbot
|
|
|
'include' imported but unused |
reviewbot
|
|
|
'HeaderDropdownActionHook' imported but unused |
reviewbot
|
|
|
This should probably be "TogetherJS", and wrapped in _() |
david
|
|
|
This doesn't seem to be used. |
david
|
|
|
None of this is used (you're using the built-in configure view now) |
david
|
|
|
Col: 1 W191 indentation contains tabs |
reviewbot
|
|
|
Col: 2 E126 continuation line over-indented for hanging indent |
reviewbot
|
|
|
Col: 1 E101 indentation contains mixed spaces and tabs |
reviewbot
|
|
|
Col: 5 E131 continuation line unaligned for hanging indent |
reviewbot
|
|
|
All of this could go on the same line. |
david
|
|
|
I'm thinking we should probably bundle the togetherjs script and include it in the js bundle. Then we can get … |
david
|
|
|
This doesn't seem like a very good label. |
david
|
|
|
This should probably be kept inside the TogetherJS.Extension class. |
david
|
|
|
Should be 4-space indent. |
david
|
|
|
Doesn't this shadow the TogetherJS function? |
david
|
|
|
Is this variable used inside TogetherJS's code? Does it really need to be re-defined here? |
david
|
|
|
Variable definitions should be the first line in the function. The superclass method should also be called with any arguments: … |
david
|
|
|
Col: 80 E501 line too long (89 > 79 characters) |
reviewbot
|
|
|
Col: 9 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 80 E501 line too long (89 > 79 characters) |
reviewbot
|
|
|
Col: 9 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 2 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 1 W191 indentation contains tabs |
reviewbot
|
|
|
Col: 1 E101 indentation contains mixed spaces and tabs |
reviewbot
|
|
|
Col: 9 E122 continuation line missing indentation or outdented |
reviewbot
|
|
|
Col: 25 E127 continuation line over-indented for visual indent |
reviewbot
|
|
|
This should be: urlpatterns = patterns( '', url(r'^$', 'reviewboard.....', { ... }) ) That will fix your ReviewBot problem. When … |
 chipx86
|
|
|
Col: 21 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 21 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
This, and lines 4-8 seem redundant after what's going on in initialize. |
 mike_conley
|
|
|
Col: 21 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 5 E124 closing bracket does not match visual indentation |
reviewbot
|
|
|
This can be deleted now, right? |
david
|
|
|
Add a trailing comma here. |
david
|
|
|
'TemplateHook' imported but unused |
reviewbot
|
|
|
We shouldn't make this a requirement for people to get up and running. We should make it default to the … |
mike_conley
|
|
|
"Copy or write down" -> "Make note of". |
mike_conley
|
|
|
Trailing whitespace. |
david
|
|
|
This file was in a different change. Can you pull the latest master and rebase your branch? |
david
|
|
|
Instead of defining these up here, just define them when they're first assigned. |
mike_conley
|
|
|
What happens if hub_url is not defined? The reason I ask, is that we might want to make it easy … |
mike_conley
|
|
|
This file shouldn't be called "*-min.js" because it's not minified. |
david
|
|
|
Nit - instead of "where TogetherJS is listed", it'd be "where ReviewTogether is listed", or whatever is actually listed in … |
mike_conley
|
|
|
You might want to double-check with one of the other mentors that this style of breaking lines is legit. Looks … |
mike_conley
|
|
|
reviewboard -> Review Board |
mike_conley
|
|
|
let's break the list over two lines: 'source_filenames': ['js/togetherjs.js', 'js/review-together.js',] |
mike_conley
|
|
|
ReviewBoard -> Review Board. |
mike_conley
|
|
|
I don't think this comment adds much - can be safely removed. |
mike_conley
|
|
|
This change should have already landed as part of your change from /r/6066... Are you sure you have an up-to-date … |
mike_conley
|
|
|
Like I said in IRC, let's just do: if (settings.hub_url) { // Set the TogetherJSConfig_hubBase variable } |
mike_conley
|
|
|
Ok, now I'm really confused... This patch is the base of /r/6194 - I get that... But what is this … |
mike_conley
|
|
|
'JSExtension' imported but unused |
reviewbot
|
|
|
undefined name 'ReviewTogetherJSExtension' |
reviewbot
|
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+21) |
-
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/views.py Ignored Files: review_together/review_together/templates/review_together/configure.html Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/views.py Ignored Files: review_together/review_together/templates/review_together/configure.html
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+34) |
-
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/views.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/templates/review_together/configure.html Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/views.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/templates/review_together/configure.html -
review_together/review_together/admin_urls.py (Diff revision 3) Col: 5 E128 continuation line under-indented for visual indent
-
review_together/review_together/admin_urls.py (Diff revision 3) Col: 2 W292 no newline at end of file
-
-
-
-
review_together/review_together/extension.py (Diff revision 3) 'HeaderDropdownActionHook' imported but unused
-
-
review_together/review_together/admin_urls.py (Diff revision 3) This isn't used anymore (since 'urlpatterns' is redefined below).
-
review_together/review_together/forms.py (Diff revision 3) This should probably be "TogetherJS", and wrapped in
_() -
review_together/review_together/templates/review_together/configure.html (Diff revision 3) This doesn't seem to be used.
-
review_together/review_together/views.py (Diff revision 3) None of this is used (you're using the built-in configure view now)
PE
Description: |
|
||||||
|---|---|---|---|---|---|---|---|
Commit: |
|
||||||
Diff: |
Revision 4 (+54 -15) |
-
Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/together.js review_together/review_together/templates/review_together/base.html Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/together.js review_together/review_together/templates/review_together/base.html -
review_together/review_together/admin_urls.py (Diff revision 4) Col: 1 W191 indentation contains tabs
-
review_together/review_together/admin_urls.py (Diff revision 4) Col: 2 E126 continuation line over-indented for hanging indent
-
review_together/review_together/admin_urls.py (Diff revision 4) Col: 1 E101 indentation contains mixed spaces and tabs
-
review_together/review_together/admin_urls.py (Diff revision 4) Col: 5 E131 continuation line unaligned for hanging indent
PE
Summary: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 5 (+55 -15) |
-
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/together.js review_together/review_together/templates/review_together/base.html Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/together.js review_together/review_together/templates/review_together/base.html
-
-
review_together/review_together/admin_urls.py (Diff revision 5) All of this could go on the same line.
-
review_together/review_together/extension.py (Diff revision 5) I'm thinking we should probably bundle the togetherjs script and include it in the js bundle. Then we can get rid of this template entirely.
-
review_together/review_together/forms.py (Diff revision 5) This doesn't seem like a very good label.
-
review_together/review_together/static/js/together.js (Diff revision 5) This should probably be kept inside the
TogetherJS.Extensionclass. -
-
review_together/review_together/static/js/together.js (Diff revision 5) Doesn't this shadow the TogetherJS function?
-
review_together/review_together/static/js/together.js (Diff revision 5) Is this variable used inside TogetherJS's code? Does it really need to be re-defined here?
-
review_together/review_together/static/js/together.js (Diff revision 5) Variable definitions should be the first line in the function. The superclass method should also be called with any arguments:
initialize: function() { var settings; _super(this).initialize.apply(this, arguments); settings = this.get('settings'); TogetherJSConfig_hubBase = settings.hub_url; }
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 6 (+54 -15) |
-
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/together.js review_together/review_together/templates/review_together/base.html Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/together.js review_together/review_together/templates/review_together/base.html -
review_together/review_together/admin_urls.py (Diff revision 6) Col: 80 E501 line too long (89 > 79 characters)
-
review_together/review_together/admin_urls.py (Diff revision 6) Col: 9 E128 continuation line under-indented for visual indent
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 7 (+171 -11) |
-
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less -
review_together/review_together/admin_urls.py (Diff revision 7) Col: 80 E501 line too long (89 > 79 characters)
-
review_together/review_together/admin_urls.py (Diff revision 7) Col: 9 E128 continuation line under-indented for visual indent
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 8 (+172 -11) |
-
Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less -
review_together/review_together/admin_urls.py (Diff revision 8) Col: 2 E128 continuation line under-indented for visual indent
-
review_together/review_together/admin_urls.py (Diff revision 8) Col: 1 W191 indentation contains tabs
-
review_together/review_together/admin_urls.py (Diff revision 8) Col: 1 E101 indentation contains mixed spaces and tabs
-
review_together/review_together/admin_urls.py (Diff revision 8) Col: 9 E122 continuation line missing indentation or outdented
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 9 (+173 -12) |
-
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less -
review_together/review_together/admin_urls.py (Diff revision 9) Col: 25 E127 continuation line over-indented for visual indent
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 10 (+173 -12) |
-
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less -
review_together/review_together/admin_urls.py (Diff revision 10) Col: 21 E128 continuation line under-indented for visual indent
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 11 (+983 -22) |
-
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs-min.js review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs-min.js review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html -
review_together/review_together/admin_urls.py (Diff revision 11) Col: 21 E128 continuation line under-indented for visual indent
-
-
review_together/review_together/static/js/together.js (Diff revision 11) This, and lines 4-8 seem redundant after what's going on in initialize.
-
review_together/review_together/static/js/together.js (Diff revision 11) Is TogetherJSConfig_hubBase a global that the TogetherJS library reads?
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 12 (+976 -22) |
-
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs-min.js review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs-min.js review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html -
review_together/review_together/admin_urls.py (Diff revision 12) Col: 21 E128 continuation line under-indented for visual indent
-
-
review_together/review_together/admin_urls.py (Diff revision 10) This should be:
urlpatterns = patterns( '', url(r'^$', 'reviewboard.....', { ... }) )That will fix your ReviewBot problem.
When in doubt, look at how the rest of the Review Board codebase is doing things, for inspiration.
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 13 (+978 -21) |
-
Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs-min.js review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs-min.js review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html -
review_together/review_together/admin_urls.py (Diff revision 13) Col: 5 E124 closing bracket does not match visual indentation
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 14 (+977 -21) |
-
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs-min.js review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs-min.js review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 15 (+989 -22) |
-
Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs-min.js review_together/README.md review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs-min.js review_together/README.md review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html -
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 16 (+989 -22) |
-
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs-min.js review_together/README.md review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs-min.js review_together/README.md review_together/review_together/static/js/together.js review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html
-
-
-
review_together/review_together/static/css/review-together.less (Diff revision 16) This file was in a different change. Can you pull the latest master and rebase your branch?
-
review_together/review_together/static/js/togetherjs-min.js (Diff revision 16) This file shouldn't be called "*-min.js" because it's not minified.
-
-
review_together/README.md (Diff revision 16) We shouldn't make this a requirement for people to get up and running. We should make it default to the Mozilla hub, but then tell them how to override with their own hub here.
-
-
review_together/review_together/static/js/together.js (Diff revision 16) Instead of defining these up here, just define them when they're first assigned.
-
review_together/review_together/static/js/together.js (Diff revision 16) What happens if hub_url is not defined? The reason I ask, is that we might want to make it easy for people to get Review Together up and running and working, without making them set up a Hub server.
So is it possible to have this default to the Mozilla hub server if blank?
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 17 (+989 -22) |
-
Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs.js review_together/review_together/static/js/review-together.js review_together/README.md review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs.js review_together/review_together/static/js/review-together.js review_together/README.md review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 18 (+992 -22) |
-
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs.js review_together/review_together/static/js/review-together.js review_together/README.md review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs.js review_together/review_together/static/js/review-together.js review_together/README.md review_together/review_together/static/css/review-together.less review_together/review_together/templates/review_together/base.html
-
-
review_together/README.md (Diff revision 18) Nit - instead of "where TogetherJS is listed", it'd be "where ReviewTogether is listed", or whatever is actually listed in the Extension manager.
-
review_together/review_together/admin_urls.py (Diff revision 18) You might want to double-check with one of the other mentors that this style of breaking lines is legit. Looks like pep8 likes it, but something looks off here. Maybe I'm just imagining it though.
-
-
review_together/review_together/extension.py (Diff revision 18) let's break the list over two lines:
'source_filenames': ['js/togetherjs.js',
'js/review-together.js',] -
-
review_together/review_together/extension.py (Diff revision 18) I don't think this comment adds much - can be safely removed.
-
review_together/review_together/static/css/review-together.less (Diff revision 18) This change should have already landed as part of your change from /r/6066...
Are you sure you have an up-to-date rb-extension-pack repo?
-
review_together/review_together/static/js/review-together.js (Diff revision 18) Like I said in IRC, let's just do:
if (settings.hub_url) {
// Set the TogetherJSConfig_hubBase variable
}
PE
Testing Done: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||||||||
Diff: |
Revision 19 (+17 -17) |
-
Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs.js review_together/review_together/static/js/review-together.js review_together/README.md Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs.js review_together/review_together/static/js/review-together.js review_together/README.md
-
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs.js review_together/review_together/static/js/review-together.js review_together/README.md Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/togetherjs.js review_together/review_together/static/js/review-together.js review_together/README.md
-
Hrm - something is fishy here... it looks like your review request is based on code that's not yet landed. For example, looking at the diff, I see you mucking about in JS files under review_together/static/js... but on master, no such directory exists: https://github.com/reviewboard/rb-extension-pack/tree/master/review_together/review_together/static
-
-
review_together/README.md (Diff revision 20) Ok, now I'm really confused...
This patch is the base of /r/6194 - I get that...
But what is this patch based off of? The changes in this patch appear to be applied on top of things that are not yet in the rb-extensions-pack/review_together folder.
For example, this line: "To get Review Together running, you will need to run a TogetherJS hub."
That you're changing... where did that get introduced? Did we miss a commit somewhere?
-
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/review-together.js review_together/README.md Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/review-together.js review_together/README.md -
-
review_together/review_together/extension.py (Diff revision 21) undefined name 'ReviewTogetherJSExtension'
PE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 22 (+76 -10) |
-
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/review-together.js review_together/README.md Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/admin_urls.py review_together/review_together/extension.py Ignored Files: review_together/review_together/static/js/review-together.js review_together/README.md
Tool: PEP8 Style Checker Processed Files: review_together/review_together/forms.py review_together/review_together/views.py Ignored Files: review_together/review_together/templates/review_together/configure.html Tool: Pyflakes Processed Files: review_together/review_together/forms.py review_together/review_together/views.py Ignored Files: review_together/review_together/templates/review_together/configure.html