Summary

Switch to the new template loaders from Djblets.

Review Request #6092 — Created July 10, 2014 and submitted July 11, 2014, 1:58 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

3d52917...

Reviewers

Groups

reviewboard

People

Description

This updates our list of template loaders to use the new

conditional_cached (which only caches if DEBUG = False) and

namespaced_app_dirs (which allows app module prefixes for paths).

Testing Done

Unit tests pass.

Had no issues using the site. Didn't see things cached when DEBUG was True.

I was able to use a prefix for an upcoming change.

Issues

Description	From	Last Updated
'from settings_local import *' used; unable to detect undefined names	reviewbot	July 11, 2014, 1:58 a.m.
'PIPELINE_JS' imported but unused	reviewbot	July 11, 2014, 1:58 a.m.
'PIPELINE_CSS' imported but unused	reviewbot	July 11, 2014, 1:58 a.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py



Tool: Pyflakes
Processed Files:
    reviewboard/settings.py

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (a6e198c)

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 1)