Summary

Remove unnecessary apps from INSTALLED_APPS.

Review Request #6085 — Created July 8, 2014 and submitted July 10, 2014, 1:38 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

53b7e01...

Reviewers

Groups

reviewboard

People

Description

Modules only need to be in INSTALLED_APPS if they provide models,
templates, template tags, or other such things. We have a few entries
listed that do not need to be there.

One of these, djblets.webapi, introduced problems when we added models
to reviewboard.webapi. App labels must be unique in INSTALLED_APPS,
due to several assumptions in Django, which was the source of this
problem. (Note that we still violate this all over the place, but it
doesn't seem to matter too much right now for the others.)

Testing Done

Tested that the dashboard, review UIs, API, and SSH still work.

All unit tests pass.

Issues

Description	From	Last Updated
'from settings_local import *' used; unable to detect undefined names	reviewbot	July 10, 2014, 1:37 a.m.
'PIPELINE_CSS' imported but unused	reviewbot	July 10, 2014, 1:37 a.m.
'PIPELINE_JS' imported but unused	reviewbot	July 10, 2014, 1:37 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/settings.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (817b9d8)

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 1)