Summary

Cache lookups of LocalSites in the API unit tests.

Review Request #6084 — Created July 8, 2014 and submitted July 22, 2014, 6:28 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

47c57e5...

Reviewers

Groups

reviewboard

People

Description

We fetch LocalSites quite a lot in the API unit tests. This attempts to
reduce the number of queries by caching and returning them after they've
already been queried once.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
'LocalSite' imported but unused	reviewbot	July 10, 2014, 2:02 a.m.
'LocalSite' imported but unused	reviewbot	July 10, 2014, 2:03 a.m.
'LocalSite' imported but unused	reviewbot	July 10, 2014, 2:03 a.m.
'LocalSite' imported but unused	reviewbot	July 10, 2014, 2:03 a.m.
'LocalSite' imported but unused	reviewbot	July 10, 2014, 2:03 a.m.
'LocalSite' imported but unused	reviewbot	July 10, 2014, 2:04 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_review_group.py
    reviewboard/webapi/tests/test_hosting_service_account.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/tests/test_review_request_draft.py
    reviewboard/webapi/tests/test_default_reviewer.py
    reviewboard/webapi/tests/test_review_group_user.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/webapi/tests/base.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_review_group.py
    reviewboard/webapi/tests/test_hosting_service_account.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/tests/test_review_request_draft.py
    reviewboard/webapi/tests/test_default_reviewer.py
    reviewboard/webapi/tests/test_review_group_user.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/webapi/tests/base.py

reviewboard/webapi/tests/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'LocalSite' imported but unused
```
reviewboard/webapi/tests/test_default_reviewer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'LocalSite' imported but unused
```
reviewboard/webapi/tests/test_hosting_service_account.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'LocalSite' imported but unused
```
reviewboard/webapi/tests/test_review_group_user.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'LocalSite' imported but unused
```
reviewboard/webapi/tests/test_review_request_draft.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'LocalSite' imported but unused
```
reviewboard/webapi/tests/test_user.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'LocalSite' imported but unused
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (0b9a469)