Change Summary:
Deleted trailing whitespace
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+37) |
Review Request #6078 — Created July 8, 2014 and discarded
Information | |
---|---|
salam0smy | |
rb-extension-pack | |
Reviewers | |
students | |
Created a new model to hold templates for the checklist extension. The model contains a name for the list, and a collection of template items. Items can be added, edited and removed from the model.
I followed the same schema as ReviewChecklist model.
Description | From | Last Updated |
---|---|---|
Col: 1 E302 expected 2 blank lines, found 1 |
![]() |
|
Col: 80 E501 line too long (80 > 79 characters) |
![]() |
|
Col: 35 W291 trailing whitespace |
![]() |
|
Col: 1 W293 blank line contains whitespace |
![]() |
|
Col: 1 E302 expected 2 blank lines, found 1 |
![]() |
|
Col: 80 E501 line too long (80 > 79 characters) |
![]() |
|
How about just calling this ChecklistTemplate. Adding another List on the end seems superfluous. |
|
|
This isn't "making the review", it's the user who owns the template. |
|
|
Do we really need to have unique IDs for items? We're not keeping track of any checked state for them. |
|
|
Can you please call this items (or perhaps template_items). The name temp_items makes me think that they're temporary items. |
|
|
Add a trailing comma. |
|
|
I know it's in the code above, but I'm not sure why we have to convert to str for all … |
|
|
You don't need the parens around the conditional. |
|
|
You don't need the parens around the conditional. |
|
Deleted trailing whitespace
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+37) |
Tool: PEP8 Style Checker Processed Files: checklist/checklist/models.py Tool: Pyflakes Processed Files: checklist/checklist/models.py
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+38) |
Tool: PEP8 Style Checker Processed Files: checklist/checklist/models.py Tool: Pyflakes Processed Files: checklist/checklist/models.py
checklist/checklist/models.py (Diff revision 3) |
---|
How about just calling this
ChecklistTemplate
. Adding anotherList
on the end seems superfluous.
checklist/checklist/models.py (Diff revision 3) |
---|
This isn't "making the review", it's the user who owns the template.
checklist/checklist/models.py (Diff revision 3) |
---|
Do we really need to have unique IDs for items? We're not keeping track of any checked state for them.
checklist/checklist/models.py (Diff revision 3) |
---|
Can you please call this
items
(or perhapstemplate_items
). The nametemp_items
makes me think that they're temporary items.
checklist/checklist/models.py (Diff revision 3) |
---|
I know it's in the code above, but I'm not sure why we have to convert to str for all of this.
Changed model class name, field name, no longer cast id to string for edit and remove
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+38) |