Summary

Checklist Extension template model

Review Request #6078 — Created July 8, 2014 and discarded Dec. 10, 2014, 4:54 p.m.

Information

Owner

salam0smy

Repository

rb-extension-pack

Branch

Bugs

Depends On

Reviewers

Groups

students

People

Description

Created a new model to hold templates for the checklist extension. The model contains a name for the list, and a collection of template items. Items can be added, edited and removed from the model.
I followed the same schema as ReviewChecklist model.

Testing Done

Issues

Description	From	Last Updated
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	July 10, 2014, 1:14 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	July 10, 2014, 1:14 p.m.
Col: 35 W291 trailing whitespace	reviewbot	July 10, 2014, 1:14 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	July 10, 2014, 1:14 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	July 10, 2014, 1:14 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	July 10, 2014, 1:14 p.m.
How about just calling this ChecklistTemplate. Adding another List on the end seems superfluous.	david	July 15, 2014, 10:19 p.m.
This isn't "making the review", it's the user who owns the template.	david	July 15, 2014, 10:19 p.m.
Do we really need to have unique IDs for items? We're not keeping track of any checked state for them.	david	Aug. 10, 2014, 6:26 p.m.
Can you please call this items (or perhaps template_items). The name temp_items makes me think that they're temporary items.	david	July 15, 2014, 10:19 p.m.
Add a trailing comma.	david	July 15, 2014, 10:19 p.m.
I know it's in the code above, but I'm not sure why we have to convert to str for all …	david	July 15, 2014, 10:20 p.m.
You don't need the parens around the conditional.	david	July 15, 2014, 10:20 p.m.
You don't need the parens around the conditional.	david	July 15, 2014, 10:20 p.m.

Change Summary:

Deleted trailing whitespace

Commit:

c88de0f7e01fd8443b7f37edcba175e5aaed2c09

1036a7fface5f52cdf4228115075437e6910776e

Diff:

Revision 2 (+37)

Show changes

checklist/checklist/models.py

Tool: Pyflakes
Processed Files:
    checklist/checklist/models.py



Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/models.py

checklist/checklist/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
checklist/checklist/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/models.py



Tool: Pyflakes
Processed Files:
    checklist/checklist/models.py

checklist/checklist/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
checklist/checklist/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
checklist/checklist/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 35
 W291 trailing whitespace
```
checklist/checklist/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```

Commit:

1036a7fface5f52cdf4228115075437e6910776e

dff8fe1711d825362b4febc8140a91f863467d67

Diff:

Revision 3 (+38)

Show changes

checklist/checklist/models.py

Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/models.py



Tool: Pyflakes
Processed Files:
    checklist/checklist/models.py

checklist/checklist/models.py (Diff revision 3)

The issue has been resolved. Show all issues

How about just calling this ChecklistTemplate. Adding another List on the end seems superfluous.

checklist/checklist/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This isn't "making the review", it's the user who owns the template.
```

checklist/checklist/models.py (Diff revision 3)

The issue has been resolved. Show all issues

Do we really need to have unique IDs for items? We're not keeping track of any checked state for them.

salam0smy July 15, 2014, 10:06 p.m.

Isn't it neccesery for editing or deleting individual items?

checklist/checklist/models.py (Diff revision 3)

The issue has been resolved. Show all issues

Can you please call this items (or perhaps template_items). The name temp_items makes me think that they're temporary items.

checklist/checklist/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Add a trailing comma.
```

checklist/checklist/models.py (Diff revision 3)

The issue has been resolved. Show all issues

I know it's in the code above, but I'm not sure why we have to convert to str for all of this.

checklist/checklist/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
You don't need the parens around the conditional.
```
checklist/checklist/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
You don't need the parens around the conditional.
```

Change Summary:

Changed model class name, field name, no longer cast id to string for edit and remove

Commit:

dff8fe1711d825362b4febc8140a91f863467d67

f483b120456771a457928ddfae3786c038e00bd5

Diff:

Revision 4 (+38)

Show changes

checklist/checklist/models.py

Tool: PEP8 Style Checker
Processed Files:
    checklist/checklist/models.py



Tool: Pyflakes
Processed Files:
    checklist/checklist/models.py

Status:: Discarded