-
-
reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 1) local variable 'h' is assigned to but never used
-
reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 1) local variable 'w' is assigned to but never used
-
reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 1) local variable 'y' is assigned to but never used
-
reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 1) local variable 'x' is assigned to but never used
Use more specific assertions for 'in' checks.
Review Request #6064 — Created July 4, 2014 and submitted
Information | |
---|---|
chipx86 | |
Review Board | |
release-2.0.x | |
3797c0d... | |
Reviewers | |
reviewboard | |
A lot of old code used
assertTrue(blah in blah)
, or variants on that,
which didn't tell you much if there was a failure. Nowadays, we have
assertIn
andassertNotIn
, which we can use instead. This switches our
tests to use these.
Unit tests pass.
