Use more specific assertions for 'in' checks.

Review Request #6064 — Created July 4, 2014 and submitted

Information

Review Board
release-2.0.x
3797c0d...

Reviewers

A lot of old code used assertTrue(blah in blah), or variants on that,
which didn't tell you much if there was a failure. Nowadays, we have
assertIn and assertNotIn, which we can use instead. This switches our
tests to use these.

Unit tests pass.

Description From Last Updated

local variable 'h' is assigned to but never used

reviewbotreviewbot

local variable 'w' is assigned to but never used

reviewbotreviewbot

local variable 'y' is assigned to but never used

reviewbotreviewbot

local variable 'x' is assigned to but never used

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/tests/test_review_screenshot_comment.py
        reviewboard/webapi/tests/test_watched_review_group.py
        reviewboard/scmtools/tests.py
        reviewboard/webapi/tests/test_diff_file_attachment.py
        reviewboard/diffviewer/tests.py
        reviewboard/webapi/tests/test_default_reviewer.py
        reviewboard/webapi/tests/test_draft_filediff.py
        reviewboard/webapi/tests/test_review_comment.py
        reviewboard/extensions/tests.py
        reviewboard/webapi/tests/test_file_attachment_draft.py
        reviewboard/webapi/tests/test_change.py
        reviewboard/webapi/tests/test_review_reply.py
        reviewboard/changedescs/tests.py
        reviewboard/webapi/tests/test_server_info.py
        reviewboard/webapi/tests/mixins.py
        reviewboard/webapi/tests/test_user.py
        reviewboard/webapi/tests/base.py
        reviewboard/webapi/tests/test_session.py
        reviewboard/webapi/tests/mixins_comment.py
        reviewboard/reviews/tests.py
        reviewboard/webapi/tests/test_review_request.py
        reviewboard/hostingsvcs/tests.py
        reviewboard/webapi/tests/test_draft_diff.py
        reviewboard/webapi/tests/test_diff.py
        reviewboard/webapi/tests/test_repository.py
        reviewboard/webapi/tests/test_validate_diff.py
        reviewboard/webapi/tests/test_root.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/tests/test_review_screenshot_comment.py
        reviewboard/webapi/tests/test_watched_review_group.py
        reviewboard/scmtools/tests.py
        reviewboard/webapi/tests/test_diff_file_attachment.py
        reviewboard/diffviewer/tests.py
        reviewboard/webapi/tests/test_default_reviewer.py
        reviewboard/webapi/tests/test_draft_filediff.py
        reviewboard/webapi/tests/test_review_comment.py
        reviewboard/extensions/tests.py
        reviewboard/webapi/tests/test_file_attachment_draft.py
        reviewboard/webapi/tests/test_change.py
        reviewboard/webapi/tests/test_review_reply.py
        reviewboard/changedescs/tests.py
        reviewboard/webapi/tests/test_server_info.py
        reviewboard/webapi/tests/mixins.py
        reviewboard/webapi/tests/test_user.py
        reviewboard/webapi/tests/base.py
        reviewboard/webapi/tests/test_session.py
        reviewboard/webapi/tests/mixins_comment.py
        reviewboard/reviews/tests.py
        reviewboard/webapi/tests/test_review_request.py
        reviewboard/hostingsvcs/tests.py
        reviewboard/webapi/tests/test_draft_diff.py
        reviewboard/webapi/tests/test_diff.py
        reviewboard/webapi/tests/test_repository.py
        reviewboard/webapi/tests/test_validate_diff.py
        reviewboard/webapi/tests/test_root.py
    
    
  2.  local variable 'h' is assigned to but never used
    
  3.  local variable 'w' is assigned to but never used
    
  4.  local variable 'y' is assigned to but never used
    
  5.  local variable 'x' is assigned to but never used
    
  6. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (1758bf5)
Loading...