Summary

Use more specific assertions for 'in' checks.

Review Request #6064 — Created July 4, 2014 and submitted July 6, 2014, 6:32 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

3797c0d...

Reviewers

Groups

reviewboard

People

Description

A lot of old code used assertTrue(blah in blah), or variants on that,
which didn't tell you much if there was a failure. Nowadays, we have
assertIn and assertNotIn, which we can use instead. This switches our
tests to use these.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
local variable 'h' is assigned to but never used	reviewbot	July 5, 2014, 1:49 a.m.
local variable 'w' is assigned to but never used	reviewbot	July 5, 2014, 1:49 a.m.
local variable 'y' is assigned to but never used	reviewbot	July 5, 2014, 1:49 a.m.
local variable 'x' is assigned to but never used	reviewbot	July 5, 2014, 1:49 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/test_review_screenshot_comment.py
    reviewboard/webapi/tests/test_watched_review_group.py
    reviewboard/scmtools/tests.py
    reviewboard/webapi/tests/test_diff_file_attachment.py
    reviewboard/diffviewer/tests.py
    reviewboard/webapi/tests/test_default_reviewer.py
    reviewboard/webapi/tests/test_draft_filediff.py
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/extensions/tests.py
    reviewboard/webapi/tests/test_file_attachment_draft.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/webapi/tests/test_review_reply.py
    reviewboard/changedescs/tests.py
    reviewboard/webapi/tests/test_server_info.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/tests/test_session.py
    reviewboard/webapi/tests/mixins_comment.py
    reviewboard/reviews/tests.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/hostingsvcs/tests.py
    reviewboard/webapi/tests/test_draft_diff.py
    reviewboard/webapi/tests/test_diff.py
    reviewboard/webapi/tests/test_repository.py
    reviewboard/webapi/tests/test_validate_diff.py
    reviewboard/webapi/tests/test_root.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/test_review_screenshot_comment.py
    reviewboard/webapi/tests/test_watched_review_group.py
    reviewboard/scmtools/tests.py
    reviewboard/webapi/tests/test_diff_file_attachment.py
    reviewboard/diffviewer/tests.py
    reviewboard/webapi/tests/test_default_reviewer.py
    reviewboard/webapi/tests/test_draft_filediff.py
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/extensions/tests.py
    reviewboard/webapi/tests/test_file_attachment_draft.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/webapi/tests/test_review_reply.py
    reviewboard/changedescs/tests.py
    reviewboard/webapi/tests/test_server_info.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/tests/test_session.py
    reviewboard/webapi/tests/mixins_comment.py
    reviewboard/reviews/tests.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/hostingsvcs/tests.py
    reviewboard/webapi/tests/test_draft_diff.py
    reviewboard/webapi/tests/test_diff.py
    reviewboard/webapi/tests/test_repository.py
    reviewboard/webapi/tests/test_validate_diff.py
    reviewboard/webapi/tests/test_root.py

reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 local variable 'h' is assigned to but never used
```
reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 local variable 'w' is assigned to but never used
```
reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 local variable 'y' is assigned to but never used
```
reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 local variable 'x' is assigned to but never used
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (1758bf5)