• 
      

    Clean up PyFlakes warnings and improve filtering.

    Review Request #6063 — Created July 4, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    e83d42e...

    Reviewers

    This cleans up some pyflakes warnings that were found. There were only a
    couple minor ones found in unit tests, and one entry that needed to be
    added to the exclusion file.

    This also fixes up run-pyflakes.py to exclude more files/paths by
    default, and to support excluding subdirectories listed in
    module_exclusions (in particular, reviewboard/htdocs/, which is handy if
    you upload a Python file to a review request that has pyflakes errors).

    PyFlakes no longer reported any errors or warnings.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/webapi/tests/test_review_screenshot_comment.py
          reviewboard/webapi/tests/test_repository_commits.py
          contrib/internal/run-pyflakes.py
      
      Ignored Files:
          contrib/internal/pyflakes.exclude
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/webapi/tests/test_review_screenshot_comment.py
          reviewboard/webapi/tests/test_repository_commits.py
          contrib/internal/run-pyflakes.py
      
      Ignored Files:
          contrib/internal/pyflakes.exclude
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (94604a0)