Summary

Clean up some function names in the webapi tests.

Review Request #6061 — Created July 4, 2014 and submitted July 6, 2014, 2:23 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

acebc21...

Reviewers

Groups

reviewboard

People

Description

This brings some consistency to the naming of some utility methods in
the webapi tests. The apiGet, apiPost, etc. methods have been renamed to
api_get, api_post, etc. This adds consistency and helps prevent new
contributors from seeing those and using the wrong casing.

Testing Done

Unit tests pass.

pep8 didn't complain of any alignment issues.

Issues

Description	From	Last Updated
'INVALID_FORM_DATA' imported but unused	reviewbot	July 4, 2014, 3:51 p.m.
local variable 'h' is assigned to but never used	reviewbot	July 4, 2014, 3:51 p.m.
local variable 'w' is assigned to but never used	reviewbot	July 4, 2014, 3:51 p.m.
local variable 'y' is assigned to but never used	reviewbot	July 4, 2014, 3:51 p.m.
local variable 'x' is assigned to but never used	reviewbot	July 4, 2014, 3:51 p.m.
'INVALID_FORM_DATA' imported but unused	reviewbot	July 5, 2014, 1:49 a.m.
local variable 'y' is assigned to but never used	reviewbot	July 5, 2014, 1:49 a.m.
local variable 'x' is assigned to but never used	reviewbot	July 5, 2014, 1:49 a.m.
local variable 'h' is assigned to but never used	reviewbot	July 5, 2014, 1:49 a.m.
local variable 'w' is assigned to but never used	reviewbot	July 5, 2014, 1:49 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
    reviewboard/webapi/tests/test_review_screenshot_comment.py
    reviewboard/webapi/tests/test_file_diff_comment.py
    reviewboard/webapi/tests/test_watched_review_request.py
    reviewboard/webapi/tests/test_diff_file_attachment.py
    reviewboard/webapi/tests/test_default_reviewer.py
    reviewboard/webapi/tests/test_draft_filediff.py
    reviewboard/webapi/tests/mixins_review.py
    reviewboard/webapi/tests/test_screenshot_draft.py
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/tests/test_review_group.py
    reviewboard/webapi/tests/test_file_attachment_draft.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/webapi/tests/test_review_reply.py
    reviewboard/webapi/tests/test_repository_commits.py
    reviewboard/webapi/tests/test_repository_branches.py
    reviewboard/webapi/tests/mixins_extra_data.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/tests/test_session.py
    reviewboard/webapi/tests/test_review.py
    reviewboard/webapi/tests/mixins_comment.py
    reviewboard/webapi/tests/test_watched_review_group.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/tests/test_review_request_draft.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/tests/test_draft_diff.py
    reviewboard/webapi/tests/test_diff.py
    reviewboard/webapi/tests/test_repository.py
    reviewboard/webapi/tests/test_validate_diff.py
    reviewboard/webapi/tests/test_root.py
    reviewboard/webapi/tests/test_screenshot.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_group_user.py
    reviewboard/webapi/tests/test_review_reply_diff_comment.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
    reviewboard/webapi/tests/test_review_screenshot_comment.py
    reviewboard/webapi/tests/test_file_diff_comment.py
    reviewboard/webapi/tests/test_watched_review_request.py
    reviewboard/webapi/tests/test_diff_file_attachment.py
    reviewboard/webapi/tests/test_default_reviewer.py
    reviewboard/webapi/tests/test_draft_filediff.py
    reviewboard/webapi/tests/mixins_review.py
    reviewboard/webapi/tests/test_screenshot_draft.py
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/tests/test_review_group.py
    reviewboard/webapi/tests/test_file_attachment_draft.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/webapi/tests/test_review_reply.py
    reviewboard/webapi/tests/test_repository_commits.py
    reviewboard/webapi/tests/test_repository_branches.py
    reviewboard/webapi/tests/mixins_extra_data.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/tests/test_session.py
    reviewboard/webapi/tests/test_review.py
    reviewboard/webapi/tests/mixins_comment.py
    reviewboard/webapi/tests/test_watched_review_group.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/tests/test_review_request_draft.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/tests/test_draft_diff.py
    reviewboard/webapi/tests/test_diff.py
    reviewboard/webapi/tests/test_repository.py
    reviewboard/webapi/tests/test_validate_diff.py
    reviewboard/webapi/tests/test_root.py
    reviewboard/webapi/tests/test_screenshot.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_group_user.py
    reviewboard/webapi/tests/test_review_reply_diff_comment.py

reviewboard/webapi/tests/test_repository_commits.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'INVALID_FORM_DATA' imported but unused
```
reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 local variable 'h' is assigned to but never used
```
reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 local variable 'w' is assigned to but never used
```
reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 local variable 'y' is assigned to but never used
```
reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 local variable 'x' is assigned to but never used
```

Change Summary:

The change to webapi/base.py ended up in the other change, and not this one.

Commit:

0fdf37b0e29a61596a2649121b26c7262123ee4f

acebc216ef2d338f1ba72a38c2222867923aaa9f

Diff:

Revision 2 (+351 -350)

Show changes

	reviewboard/webapi/tests/base.py
	reviewboard/webapi/tests/mixins.py
	reviewboard/webapi/tests/mixins_comment.py
	reviewboard/webapi/tests/mixins_extra_data.py
	reviewboard/webapi/tests/mixins_review.py
	reviewboard/webapi/tests/test_change.py
	reviewboard/webapi/tests/test_default_reviewer.py
	reviewboard/webapi/tests/test_diff.py
	28 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
    reviewboard/webapi/tests/test_review_screenshot_comment.py
    reviewboard/webapi/tests/test_file_diff_comment.py
    reviewboard/webapi/tests/test_watched_review_request.py
    reviewboard/webapi/tests/test_diff_file_attachment.py
    reviewboard/webapi/tests/test_default_reviewer.py
    reviewboard/webapi/tests/test_draft_filediff.py
    reviewboard/webapi/tests/mixins_review.py
    reviewboard/webapi/tests/test_screenshot_draft.py
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/tests/test_review_group.py
    reviewboard/webapi/tests/test_file_attachment_draft.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/webapi/tests/test_review_reply.py
    reviewboard/webapi/tests/test_repository_commits.py
    reviewboard/webapi/tests/test_repository_branches.py
    reviewboard/webapi/tests/mixins_extra_data.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/tests/test_session.py
    reviewboard/webapi/tests/test_review.py
    reviewboard/webapi/tests/mixins_comment.py
    reviewboard/webapi/tests/test_watched_review_group.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/tests/test_review_request_draft.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/tests/test_draft_diff.py
    reviewboard/webapi/tests/test_diff.py
    reviewboard/webapi/tests/test_repository.py
    reviewboard/webapi/tests/test_validate_diff.py
    reviewboard/webapi/tests/test_root.py
    reviewboard/webapi/tests/test_screenshot.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_group_user.py
    reviewboard/webapi/tests/test_review_reply_diff_comment.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/test_review_reply_screenshot_comment.py
    reviewboard/webapi/tests/test_review_screenshot_comment.py
    reviewboard/webapi/tests/test_file_diff_comment.py
    reviewboard/webapi/tests/test_watched_review_request.py
    reviewboard/webapi/tests/test_diff_file_attachment.py
    reviewboard/webapi/tests/test_default_reviewer.py
    reviewboard/webapi/tests/test_draft_filediff.py
    reviewboard/webapi/tests/mixins_review.py
    reviewboard/webapi/tests/test_screenshot_draft.py
    reviewboard/webapi/tests/test_review_comment.py
    reviewboard/webapi/tests/test_review_group.py
    reviewboard/webapi/tests/test_file_attachment_draft.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/webapi/tests/test_review_reply.py
    reviewboard/webapi/tests/test_repository_commits.py
    reviewboard/webapi/tests/test_repository_branches.py
    reviewboard/webapi/tests/mixins_extra_data.py
    reviewboard/webapi/tests/test_user.py
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/tests/test_session.py
    reviewboard/webapi/tests/test_review.py
    reviewboard/webapi/tests/mixins_comment.py
    reviewboard/webapi/tests/test_watched_review_group.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/tests/test_review_request_draft.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/tests/test_draft_diff.py
    reviewboard/webapi/tests/test_diff.py
    reviewboard/webapi/tests/test_repository.py
    reviewboard/webapi/tests/test_validate_diff.py
    reviewboard/webapi/tests/test_root.py
    reviewboard/webapi/tests/test_screenshot.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_group_user.py
    reviewboard/webapi/tests/test_review_reply_diff_comment.py

reviewboard/webapi/tests/test_repository_commits.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'INVALID_FORM_DATA' imported but unused
```
reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 local variable 'y' is assigned to but never used
```
reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 local variable 'x' is assigned to but never used
```
reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 local variable 'h' is assigned to but never used
```
reviewboard/webapi/tests/test_review_screenshot_comment.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 local variable 'w' is assigned to but never used
```

Ship it!

Looks good. Care to push this asap so that tests run again?

Status:: Completed