Clean up some function names in the webapi tests.
Review Request #6061 — Created July 4, 2014 and submitted
This brings some consistency to the naming of some utility methods in
the webapi tests. The apiGet, apiPost, etc. methods have been renamed to
api_get, api_post, etc. This adds consistency and helps prevent new
contributors from seeing those and using the wrong casing.
Unit tests pass.
pep8 didn't complain of any alignment issues.
Description | From | Last Updated |
---|---|---|
'INVALID_FORM_DATA' imported but unused |
reviewbot | |
local variable 'h' is assigned to but never used |
reviewbot | |
local variable 'w' is assigned to but never used |
reviewbot | |
local variable 'y' is assigned to but never used |
reviewbot | |
local variable 'x' is assigned to but never used |
reviewbot | |
'INVALID_FORM_DATA' imported but unused |
reviewbot | |
local variable 'y' is assigned to but never used |
reviewbot | |
local variable 'x' is assigned to but never used |
reviewbot | |
local variable 'h' is assigned to but never used |
reviewbot | |
local variable 'w' is assigned to but never used |
reviewbot |
- Change Summary:
-
The change to webapi/base.py ended up in the other change, and not this one.
- Commit:
-
0fdf37b0e29a61596a2649121b26c7262123ee4facebc216ef2d338f1ba72a38c2222867923aaa9f
- Diff:
-
Revision 2 (+351 -350)
-
Tool: Pyflakes Processed Files: reviewboard/webapi/tests/test_review_reply_screenshot_comment.py reviewboard/webapi/tests/test_review_screenshot_comment.py reviewboard/webapi/tests/test_file_diff_comment.py reviewboard/webapi/tests/test_watched_review_request.py reviewboard/webapi/tests/test_diff_file_attachment.py reviewboard/webapi/tests/test_default_reviewer.py reviewboard/webapi/tests/test_draft_filediff.py reviewboard/webapi/tests/mixins_review.py reviewboard/webapi/tests/test_screenshot_draft.py reviewboard/webapi/tests/test_review_comment.py reviewboard/webapi/tests/test_review_group.py reviewboard/webapi/tests/test_file_attachment_draft.py reviewboard/webapi/tests/test_change.py reviewboard/webapi/tests/test_review_reply.py reviewboard/webapi/tests/test_repository_commits.py reviewboard/webapi/tests/test_repository_branches.py reviewboard/webapi/tests/mixins_extra_data.py reviewboard/webapi/tests/test_user.py reviewboard/webapi/tests/base.py reviewboard/webapi/tests/test_session.py reviewboard/webapi/tests/test_review.py reviewboard/webapi/tests/mixins_comment.py reviewboard/webapi/tests/test_watched_review_group.py reviewboard/webapi/tests/test_review_request.py reviewboard/webapi/tests/test_review_request_draft.py reviewboard/webapi/tests/mixins.py reviewboard/webapi/tests/test_draft_diff.py reviewboard/webapi/tests/test_diff.py reviewboard/webapi/tests/test_repository.py reviewboard/webapi/tests/test_validate_diff.py reviewboard/webapi/tests/test_root.py reviewboard/webapi/tests/test_screenshot.py reviewboard/webapi/tests/test_file_attachment.py reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py reviewboard/webapi/tests/test_review_group_user.py reviewboard/webapi/tests/test_review_reply_diff_comment.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/test_review_reply_screenshot_comment.py reviewboard/webapi/tests/test_review_screenshot_comment.py reviewboard/webapi/tests/test_file_diff_comment.py reviewboard/webapi/tests/test_watched_review_request.py reviewboard/webapi/tests/test_diff_file_attachment.py reviewboard/webapi/tests/test_default_reviewer.py reviewboard/webapi/tests/test_draft_filediff.py reviewboard/webapi/tests/mixins_review.py reviewboard/webapi/tests/test_screenshot_draft.py reviewboard/webapi/tests/test_review_comment.py reviewboard/webapi/tests/test_review_group.py reviewboard/webapi/tests/test_file_attachment_draft.py reviewboard/webapi/tests/test_change.py reviewboard/webapi/tests/test_review_reply.py reviewboard/webapi/tests/test_repository_commits.py reviewboard/webapi/tests/test_repository_branches.py reviewboard/webapi/tests/mixins_extra_data.py reviewboard/webapi/tests/test_user.py reviewboard/webapi/tests/base.py reviewboard/webapi/tests/test_session.py reviewboard/webapi/tests/test_review.py reviewboard/webapi/tests/mixins_comment.py reviewboard/webapi/tests/test_watched_review_group.py reviewboard/webapi/tests/test_review_request.py reviewboard/webapi/tests/test_review_request_draft.py reviewboard/webapi/tests/mixins.py reviewboard/webapi/tests/test_draft_diff.py reviewboard/webapi/tests/test_diff.py reviewboard/webapi/tests/test_repository.py reviewboard/webapi/tests/test_validate_diff.py reviewboard/webapi/tests/test_root.py reviewboard/webapi/tests/test_screenshot.py reviewboard/webapi/tests/test_file_attachment.py reviewboard/webapi/tests/test_review_reply_file_attachment_comment.py reviewboard/webapi/tests/test_review_group_user.py reviewboard/webapi/tests/test_review_reply_diff_comment.py
-
-
-
-
-