Clean up all Djblets JavaScript warnings and errors from jshint.
Review Request #6055 — Created July 4, 2014 and submitted
This goes through and cleans up all the warnings and errors that jshint
reported. Only one of these (an extra comma) would lead to page
breakages, but the rest should help with some optimization and code
size.There were two changes made that were bigger than just using
===or
similar.datagrid.js has had its initialization code moved to the bottom of
$.datagrid, in order to define functions up-front (as jshint wanted)
instead of defining functions after being called. In practice, this
wouldn't cause any issues, though.
scrollIntoView()now caches$(window),$(document), and$(this)in order
to reduce execution time. I had to condense var statements there anyway,
so I just moved those out.
Tested the datagrid and basic operations on other pages.
Unit tests pass.
-
The changes to the .py files look fine but should be pulled out into a separate change.
-
djblets/static/djblets/js/jquery.gravy.inlineEditor.js (Diff revision 1) Mind combining these lines?
-
Change Summary:
- Removed the Python code that snuck in.
- Fixed up a couple button assignments in inlineEditor.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+95 -77) |
-
Tool: Pyflakes Ignored Files: djblets/static/djblets/js/jquery.gravy.modalBox.js djblets/static/djblets/js/jquery.gravy.retina.js djblets/static/djblets/js/jquery.gravy.util.js djblets/static/djblets/js/jquery.gravy.inlineEditor.js djblets/static/djblets/js/extensions/views/extensionManagerView.js djblets/static/djblets/js/jquery.gravy.hacks.js djblets/static/djblets/js/jquery.gravy.funcQueue.js djblets/static/djblets/js/extensions/models/extensionManagerModel.js djblets/static/djblets/js/datagrid.js djblets/static/djblets/js/jquery.gravy.autosize.js Tool: PEP8 Style Checker Ignored Files: djblets/static/djblets/js/jquery.gravy.modalBox.js djblets/static/djblets/js/jquery.gravy.retina.js djblets/static/djblets/js/jquery.gravy.util.js djblets/static/djblets/js/jquery.gravy.inlineEditor.js djblets/static/djblets/js/extensions/views/extensionManagerView.js djblets/static/djblets/js/jquery.gravy.hacks.js djblets/static/djblets/js/jquery.gravy.funcQueue.js djblets/static/djblets/js/extensions/models/extensionManagerModel.js djblets/static/djblets/js/datagrid.js djblets/static/djblets/js/jquery.gravy.autosize.js
Tool: Pyflakes Processed Files: djblets/extensions/packaging.py djblets/extensions/tests.py Ignored Files: djblets/static/djblets/js/jquery.gravy.modalBox.js djblets/static/djblets/js/jquery.gravy.retina.js djblets/static/djblets/js/jquery.gravy.util.js djblets/static/djblets/js/jquery.gravy.inlineEditor.js djblets/static/djblets/js/extensions/views/extensionManagerView.js djblets/static/djblets/js/jquery.gravy.hacks.js djblets/static/djblets/js/jquery.gravy.funcQueue.js djblets/static/djblets/js/extensions/models/extensionManagerModel.js djblets/static/djblets/js/datagrid.js djblets/static/djblets/js/jquery.gravy.autosize.js Tool: PEP8 Style Checker Processed Files: djblets/extensions/packaging.py djblets/extensions/tests.py Ignored Files: djblets/static/djblets/js/jquery.gravy.modalBox.js djblets/static/djblets/js/jquery.gravy.retina.js djblets/static/djblets/js/jquery.gravy.util.js djblets/static/djblets/js/jquery.gravy.inlineEditor.js djblets/static/djblets/js/extensions/views/extensionManagerView.js djblets/static/djblets/js/jquery.gravy.hacks.js djblets/static/djblets/js/jquery.gravy.funcQueue.js djblets/static/djblets/js/extensions/models/extensionManagerModel.js djblets/static/djblets/js/datagrid.js djblets/static/djblets/js/jquery.gravy.autosize.js