Summary

Refactor $.fn.bug_infobox and $.fn.user_infobox to share code.

Review Request #6053 — Created July 3, 2014 and submitted July 11, 2014, 12:54 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

8ddbed0...

Reviewers

Groups

reviewboard

People

Description

This is the first step in refactoring the infoboxes to use backbone models and
views. The code for user and bug infoboxes was substantially similar, and
there's no reason why they had to be separate. All of the code is now shared,
and the API entry-points (bug_infobox and user_infobox) just call into the
common method and pass an ID for the infobox element.

Testing Done

Tested that both infoboxes worked as expected.

Issues

Description	From	Last Updated
The usage of yDistance was intentional, to get an offset between the bottom of the element it matches and the …	chipx86	July 3, 2014, 2:49 p.m.

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/common.js
    reviewboard/static/rb/css/common.less



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/common.js
    reviewboard/static/rb/css/common.less

reviewboard/static/rb/js/common.js (Diff revision 1)

The issue has been resolved. Show all issues

The usage of yDistance was intentional, to get an offset between the bottom of the element it matches and the top of the infobox. yOffset won't do anything in the case where the infobox appears below the link.

Commit:

4642c288ec324007cad648d269d1bda3c53f5311

8ddbed0d45d96bb30f2eecde5569ca4c70cbe4f7

Diff:

Revision 2 (+38 -95)

Show changes

	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/js/common.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/common.js
    reviewboard/static/rb/css/common.less



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/common.js
    reviewboard/static/rb/css/common.less

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (fa34530)