Fix various issues with configforms table views.
Review Request #6050 — Created July 3, 2014 and submitted
There were a few of bad assumptions made when using
TableView/TableItemViewfor configform item lists.One was that there was already a
<tbody>defined. This was the case in
the few places where we used it before, but isn't not always going to be
the case. We now add one if it's not already there.The second bad assumption was that actions go on the element. In the
case ofTableItemView, this is a<tr>. Now,ListItemView/TableItemView
subclasses can define a function to return where the actions should be
added. ForTableItemView, this defaults to the last cell in the row.The third bad assumption was that, by default,
ListItemViewwould be
used if not specified otherwise, even forTableView. Now,ListView
subclasses can define their default.Along with this, the template for
TableItemViewhas been cleaned up to
remove extra whitespace, which matches a change made recently for
ListItemView.Unit tests were added for all this. Some existing tests had to be
cleaned up, though, since they polluted prototype-level data.
Unit tests pass.
The issues I was hitting in some new code using TableItemView and TableView
were fixed.
| Description | From | Last Updated |
|---|---|---|
|
This indentation is kind of bizarre. Is it crucial to avoid extra whitespace at the beginning? This should be 1-space … |
 david
|
-
-
djblets/static/djblets/js/configForms/views/tableItemView.js (Diff revision 1) This indentation is kind of bizarre. Is it crucial to avoid extra whitespace at the beginning?
This should be 1-space indented no matter what.
Change Summary:
Removed the indentation altogether for the TableItemView template.
-
Tool: PEP8 Style Checker Processed Files: djblets/settings.py Ignored Files: djblets/static/djblets/js/configForms/views/listView.js djblets/static/djblets/js/configForms/views/tests/tableItemViewTests.js djblets/static/djblets/js/configForms/views/tests/listItemViewTests.js djblets/static/djblets/js/configForms/views/listItemView.js djblets/static/djblets/js/configForms/views/tableItemView.js djblets/static/djblets/js/configForms/views/tableView.js djblets/static/djblets/js/configForms/views/tests/tableViewTests.js Tool: Pyflakes Processed Files: djblets/settings.py Ignored Files: djblets/static/djblets/js/configForms/views/listView.js djblets/static/djblets/js/configForms/views/tests/tableItemViewTests.js djblets/static/djblets/js/configForms/views/tests/listItemViewTests.js djblets/static/djblets/js/configForms/views/listItemView.js djblets/static/djblets/js/configForms/views/tableItemView.js djblets/static/djblets/js/configForms/views/tableView.js djblets/static/djblets/js/configForms/views/tests/tableViewTests.js
Tool: Pyflakes Processed Files: djblets/settings.py Ignored Files: djblets/static/djblets/js/configForms/views/listView.js djblets/static/djblets/js/configForms/views/tests/tableItemViewTests.js djblets/static/djblets/js/configForms/views/tests/listItemViewTests.js djblets/static/djblets/js/configForms/views/listItemView.js djblets/static/djblets/js/configForms/views/tableItemView.js djblets/static/djblets/js/configForms/views/tableView.js djblets/static/djblets/js/configForms/views/tests/tableViewTests.js Tool: PEP8 Style Checker Processed Files: djblets/settings.py Ignored Files: djblets/static/djblets/js/configForms/views/listView.js djblets/static/djblets/js/configForms/views/tests/tableItemViewTests.js djblets/static/djblets/js/configForms/views/tests/listItemViewTests.js djblets/static/djblets/js/configForms/views/listItemView.js djblets/static/djblets/js/configForms/views/tableItemView.js djblets/static/djblets/js/configForms/views/tableView.js djblets/static/djblets/js/configForms/views/tests/tableViewTests.js