Tighten up the logic for looking up drafts

 






 

 


  Review Request #605
  —
  Created Oct. 21, 2008 and submitted

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board SVN (deprecated)
 









 
 

  trunk
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Our support for looking up drafts was inconsistent. Sometimes we'd do the right thing and make sure we only looked it up based on the user, and sometimes we just simply checked for a draft. We're now looking them up right in all places.

 








  


 
 

  
Passed unit tests, and the draft banner seemed right on each page.

 







 









 





  








 









 






  

 








 














 





 

  

   




david




   

   





  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      /trunk/reviewboard/reviews/views.py
      


       (Diff revision 2)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    





    
    It looks like this crept in from your other work. The template doesn't use "review" yet, so I'd prefer if you didn't add it until later. Same in a few places below.
    
  
    
 
    

 
    
  



 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 









     

    

   

  

  

   
   Loading...