Summary

Add bug infobox support for GitHub.

Review Request #6049 — Created July 3, 2014 and submitted July 11, 2014, 10:13 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

7b0acb1...

Reviewers

Groups

reviewboard

People

Description

This change adds an implementation of get_bug_info_uncached for GitHub
repositories. This is relatively straightforward (hurray for bug trackers which
give us sane results in json!). The one change I had to make was to make it so
Repository.bug_tracker_service returns an instance rather than a class, and
handles bug_tracker_use_hosting correctly.

Testing Done

Added the Review Bot repository to my server, and told it to use the hosting
service's bug tracker. Saw that links to the bugs worked, and that hovering
over bug IDs showed the infobox with the correct data.

Issues

Description	From	Last Updated
Extra debug stuff.	chipx86	July 11, 2014, 7:55 p.m.
Should combine these.	chipx86	July 11, 2014, 7:55 p.m.
Can we prefix this with "GitHub:"?	chipx86	July 11, 2014, 7:55 p.m.
list comprehension redefines 'file_attachment' from line 583	reviewbot	July 3, 2014, 7:12 p.m.
Can we separate these with a blank line?	chipx86	July 11, 2014, 7:55 p.m.
list comprehension redefines 'file_attachment' from line 583	reviewbot	July 11, 2014, 8:01 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/models.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/models.py

reviewboard/reviews/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 list comprehension redefines 'file_attachment' from line 583
```

reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Extra debug stuff.
```
reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should combine these.
```
reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we prefix this with "GitHub:"?
```
reviewboard/scmtools/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we separate these with a blank line?
```

reviewboard/scmtools/models.py (Diff revision 1)

I think what we should do is formalize bug tracker configuration in a new model and have repositories use that. We'd need to keep the old stuff around for legacy usage, but we could migrate to the new stuff for everything.

The advantage to that is that a custom URL, or a hosting service configuration, or anything, would only need to be provided once and could then be re-used for lots of repositories.

david

July 11, 2014, 7:56 p.m.
```
Let's talk about this.
```

Commit:

a3b2b117e0ceee5474fd68849833137fd488d5ef

7b0acb133e2011e47b2ad8c8d3d1a7ca1f8e518f

Diff:

Revision 2 (+47 -9)

Show changes

	reviewboard/hostingsvcs/github.py
	reviewboard/reviews/views.py
	reviewboard/scmtools/models.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/models.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/models.py

reviewboard/reviews/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 list comprehension redefines 'file_attachment' from line 583
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (ba0b236)