Add bug infobox support for GitHub.

Review Request #6049 — Created July 3, 2014 and submitted

Information

Review Board
master
7b0acb1...

Reviewers

This change adds an implementation of get_bug_info_uncached for GitHub
repositories. This is relatively straightforward (hurray for bug trackers which
give us sane results in json!). The one change I had to make was to make it so
Repository.bug_tracker_service returns an instance rather than a class, and
handles bug_tracker_use_hosting correctly.

Added the Review Bot repository to my server, and told it to use the hosting
service's bug tracker. Saw that links to the bugs worked, and that hovering
over bug IDs showed the infobox with the correct data.

Description From Last Updated

Extra debug stuff.

chipx86chipx86

Should combine these.

chipx86chipx86

Can we prefix this with "GitHub:"?

chipx86chipx86

list comprehension redefines 'file_attachment' from line 583

reviewbotreviewbot

Can we separate these with a blank line?

chipx86chipx86

list comprehension redefines 'file_attachment' from line 583

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/models.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/models.py
    
    
  2. reviewboard/reviews/views.py (Diff revision 1)
     
     
    Show all issues
     list comprehension redefines 'file_attachment' from line 583
    
  3. 
      
chipx86
  1. 
      
  2. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     
    Show all issues

    Extra debug stuff.

  3. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     
     
    Show all issues

    Should combine these.

  4. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     
    Show all issues

    Can we prefix this with "GitHub:"?

  5. reviewboard/scmtools/models.py (Diff revision 1)
     
     
     
    Show all issues

    Can we separate these with a blank line?

  6. reviewboard/scmtools/models.py (Diff revision 1)
     
     
     

    I think what we should do is formalize bug tracker configuration in a new model and have repositories use that. We'd need to keep the old stuff around for legacy usage, but we could migrate to the new stuff for everything.

    The advantage to that is that a custom URL, or a hosting service configuration, or anything, would only need to be provided once and could then be re-used for lots of repositories.

    1. Let's talk about this.

  7. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/models.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/models.py
    
    
  2. reviewboard/reviews/views.py (Diff revision 2)
     
     
    Show all issues
     list comprehension redefines 'file_attachment' from line 583
    
  3. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (ba0b236)
Loading...