-
-
-
-
reviewboard/reviews/views.py (Diff revision 1) list comprehension redefines 'file_attachment' from line 578
Add draft and close banners to review UI pages.
Review Request #6033 — Created June 27, 2014 and submitted
The review UI pages for file attachments didn't have draft or close banners,
which made it kind of confusing, especially in the case when the review request
wasn't yet published. This change adds them, and fixes up some of the issues
that resulted from it.
Tested draft, public, and closed review requests with both the text and image
review UIs. Saw all the expected banners and no javascript errors.
| Description | From | Last Updated |
|---|---|---|
|
'ChangeDescription' imported but unused |
 reviewbot
|
|
|
'ReviewRequest' imported but unused |
reviewbot
|
|
|
list comprehension redefines 'file_attachment' from line 578 |
reviewbot
|
|
|
list comprehension redefines 'file_attachment' from line 578 |
reviewbot
|
|
|
list comprehension redefines 'file_attachment' from line 578 |
reviewbot
|
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+60 -34) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/models/review_request.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/js/views/reviewRequestEditorView.js -
reviewboard/reviews/views.py (Diff revision 2) list comprehension redefines 'file_attachment' from line 578
-
Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/models/review_request.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/js/views/reviewRequestEditorView.js
-
-
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 2) Just a thought. Instead of doing all this, increasing the size of the file and all, how about adding a new
_checkResizeLayoutthat we call instead of_resizeLayout, which does the conditional check and then calls_resizeLayout?
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+61 -35) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/models/review_request.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/js/views/reviewRequestEditorView.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/models/review_request.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/js/views/reviewRequestEditorView.js -
reviewboard/reviews/views.py (Diff revision 3) list comprehension redefines 'file_attachment' from line 578
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/models/review_request.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/js/views/reviewRequestEditorView.js Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/models/review_request.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/js/views/reviewRequestEditorView.js