Summary

Add draft and close banners to review UI pages.

Review Request #6033 — Created June 27, 2014 and submitted July 1, 2014, 6:08 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

102f88b...

Reviewers

Groups

reviewboard

People

Description

The review UI pages for file attachments didn't have draft or close banners,
which made it kind of confusing, especially in the case when the review request
wasn't yet published. This change adds them, and fixes up some of the issues
that resulted from it.

Testing Done

Tested draft, public, and closed review requests with both the text and image
review UIs. Saw all the expected banners and no javascript errors.

Issues

Description	From	Last Updated
'ChangeDescription' imported but unused	reviewbot	June 27, 2014, 4:49 p.m.
'ReviewRequest' imported but unused	reviewbot	June 27, 2014, 4:49 p.m.
list comprehension redefines 'file_attachment' from line 578	reviewbot	June 27, 2014, 4:49 p.m.
list comprehension redefines 'file_attachment' from line 578	reviewbot	June 27, 2014, 4:51 p.m.
list comprehension redefines 'file_attachment' from line 578	reviewbot	July 1, 2014, 3:46 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/ui/base.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/templates/reviews/ui/base.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/ui/base.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/templates/reviews/ui/base.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/reviews/ui/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'ChangeDescription' imported but unused
```
reviewboard/reviews/ui/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'ReviewRequest' imported but unused
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 list comprehension redefines 'file_attachment' from line 578
```

Commit:

acc26ef042f5a3d90518845b6a9caf2950db20b5

a4abcebe78331f540d4681210708e10b39008ba3

Diff:

Revision 2 (+60 -34)

Show changes

	reviewboard/reviews/views.py
	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/ui/base.py
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/templates/reviews/ui/base.html

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/ui/base.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/templates/reviews/ui/base.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/reviews/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 list comprehension redefines 'file_attachment' from line 578
```

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/ui/base.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/templates/reviews/ui/base.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 2)

Just a thought. Instead of doing all this, increasing the size of the file and all, how about adding a new _checkResizeLayout that we call instead of _resizeLayout, which does the conditional check and then calls _resizeLayout?

Commit:

a4abcebe78331f540d4681210708e10b39008ba3

102f88bd0f8d23327edd13b4929e818ced93e69f

Diff:

Revision 3 (+61 -35)

Show changes

	reviewboard/reviews/views.py
	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/ui/base.py
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/templates/reviews/ui/base.html

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/ui/base.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/templates/reviews/ui/base.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/ui/base.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/templates/reviews/ui/base.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/reviews/views.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 list comprehension redefines 'file_attachment' from line 578
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (b4d5cdb)