Summary

Add an extension for a "Note to Reviewers" field on review requests.

Review Request #6026 — Created June 23, 2014 and submitted June 26, 2014, 1:18 a.m.

Information

Owner

chipx86

Repository

rb-extension-pack

Branch

Bugs

Depends On

Commit

c2d44c2...

Reviewers

Groups

reviewboard

People

Description

This extension adds a "Note to Reviewers" field below "Testing Done,"
which developers can use to give instructions on what to focus on or
to pre-answer questions that may be asked, without lumping those into
the description of the change.

This field is saved and published along with the draft.

While useful, it largely functions as a demo for how to add a simple
field.

Testing Done

Installed the extension and saved some text, and published it.

Tested with Markdown.

This is actually the extension I used when I was testing some of the custom
field hooks initially.

Issues

Description	From	Last Updated
Shouldn't "Released" be False?	david	June 25, 2014, 12:20 a.m.
These should be marked for translation too, no?	david	June 25, 2014, 12:20 a.m.

Tool: PEP8 Style Checker
Processed Files:
    rbnotefield/setup.py
    rbnotefield/rbnotefield/__init__.py
    rbnotefield/rbnotefield/extension.py

Ignored Files:
    rbnotefield/.beanbag-build.cfg



Tool: Pyflakes
Processed Files:
    rbnotefield/setup.py
    rbnotefield/rbnotefield/__init__.py
    rbnotefield/rbnotefield/extension.py

Ignored Files:
    rbnotefield/.beanbag-build.cfg

Change Summary:

Added the Framework :: Review Board classifier.

Commit:

c35076167305218c7e5f4b47f7764066273c6a5b

b790fb4a9c108bb8ee01e786e882daa9c436b34b

Diff:

Revision 2 (+127)

Show changes

	rbnotefield/.beanbag-build.cfg
	rbnotefield/setup.py
	rbnotefield/rbnotefield/__init__.py
	rbnotefield/rbnotefield/extension.py

Tool: PEP8 Style Checker
Processed Files:
    rbnotefield/setup.py
    rbnotefield/rbnotefield/__init__.py
    rbnotefield/rbnotefield/extension.py

Ignored Files:
    rbnotefield/.beanbag-build.cfg



Tool: Pyflakes
Processed Files:
    rbnotefield/setup.py
    rbnotefield/rbnotefield/__init__.py
    rbnotefield/rbnotefield/extension.py

Ignored Files:
    rbnotefield/.beanbag-build.cfg

rbnotefield/rbnotefield/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Shouldn't "Released" be False?
```
rbnotefield/rbnotefield/extension.py (Diff revision 2)
The issue has been resolved. Show all issues
```
These should be marked for translation too, no?
```

Change Summary:


Unset the release flag.
Marked strings for translation.

Commit:

b790fb4a9c108bb8ee01e786e882daa9c436b34b

c2d44c294246bd0b8c633b5f15bc4e4fa90fb863

Diff:

Revision 3 (+127)

Show changes

	rbnotefield/.beanbag-build.cfg
	rbnotefield/setup.py
	rbnotefield/rbnotefield/__init__.py
	rbnotefield/rbnotefield/extension.py

Tool: Pyflakes
Processed Files:
    rbnotefield/setup.py
    rbnotefield/rbnotefield/__init__.py
    rbnotefield/rbnotefield/extension.py

Ignored Files:
    rbnotefield/.beanbag-build.cfg



Tool: PEP8 Style Checker
Processed Files:
    rbnotefield/setup.py
    rbnotefield/rbnotefield/__init__.py
    rbnotefield/rbnotefield/extension.py

Ignored Files:
    rbnotefield/.beanbag-build.cfg

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (83a93e1)