-
-
-
reviewboard/accounts/models.py (Diff revision 1) Col: 43 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/accounts/models.py (Diff revision 1) Col: 45 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/accounts/models.py (Diff revision 1) Col: 56 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/accounts/models.py (Diff revision 1) Col: 58 E251 unexpected spaces around keyword / parameter equals
-
-
-
reviewboard/accounts/models.py (Diff revision 1) Col: 48 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/accounts/models.py (Diff revision 1) Col: 50 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/accounts/models.py (Diff revision 1) Col: 61 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/accounts/models.py (Diff revision 1) Col: 63 E251 unexpected spaces around keyword / parameter equals
-
Per-user file storage model changes
Review Request #6022 — Created June 23, 2014 and submitted
| Information | |
|---|---|
| rvaiya | |
| Review Board | |
| master | |
| 1f7043c... | |
| Reviewers | |
| reviewboard, students | |
Model changes for enabling ownership of FileAttachments
- Evolutions manually run successfully
- Test suite run
| Description | From | Last Updated |
|---|---|---|
|
Col: 5 E265 block comment should start with '# ' |
 reviewbot
|
|
|
Col: 43 E251 unexpected spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 45 E251 unexpected spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 56 E251 unexpected spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 58 E251 unexpected spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 5 E265 block comment should start with '# ' |
reviewbot
|
|
|
Col: 56 W291 trailing whitespace |
reviewbot
|
|
|
Col: 48 E251 unexpected spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 50 E251 unexpected spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 61 E251 unexpected spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 63 E251 unexpected spaces around keyword / parameter equals |
reviewbot
|
|
|
undefined name 'self' |
reviewbot
|
|
|
Col: 80 E501 line too long (95 > 79 characters) |
reviewbot
|
|
|
The first line of this file should be from __future__ import unicode_literals |
 david
|
|
|
Col: 80 E501 line too long (96 > 79 characters) |
reviewbot
|
|
|
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
Col: 80 E501 line too long (96 > 79 characters) |
reviewbot
|
|
|
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
You'll need to prepend this line to the file, followed by a blank line: from __future__ import unicode_literals This ensures … |
 chipx86
|
|
|
Imports should be alphabetical. |
chipx86
|
|
|
Since file and review_request are now optional, they should default to None. |
chipx86
|
|
|
Remove this blank line. |
chipx86
|
|
|
This is referencing file, since it's None. Doesn't look like this form was tested? |
chipx86
|
|
|
You need 2 blank lines between classes. You removed one of them. |
chipx86
|
|
|
Alphabetical. |
chipx86
|
|
|
Alphabetical. |
chipx86
|
|
|
Should name this 'file_attachments'. |
chipx86
|
|
|
No blank line here. |
chipx86
|
|
|
Since we're dealing with optional keyword arguments now, can you do: form.create(file=..., review_request=...) |
chipx86
|
|
|
'guess_mimetype' imported but unused |
reviewbot
|
|
|
undefined name 'is_exe_in_path' |
reviewbot
|
|
|
undefined name 'subprocess' |
reviewbot
|
|
|
undefined name 'subprocess' |
reviewbot
|
|
|
undefined name 'subprocess' |
reviewbot
|
|
|
undefined name 'subprocess' |
reviewbot
|
|
|
'guess_mimetype' imported but unused |
reviewbot
|
|
|
undefined name 'is_exe_in_path' |
reviewbot
|
|
|
undefined name 'subprocess' |
reviewbot
|
|
|
undefined name 'subprocess' |
reviewbot
|
|
|
undefined name 'subprocess' |
reviewbot
|
|
|
undefined name 'subprocess' |
reviewbot
|
|
|
Too many blank lines. Should only be one at this level. |
chipx86
|
RV
Change Summary:
Abandoned usage statistics as discussed at the last UCOSP meeting. Added test/evolution for simple change to the FileAttachment model.
Description: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||
Commit: |
|
|||||||||
Diff: |
Revision 2 (+24 -1) |
-
Tool: Pyflakes Processed Files: reviewboard/attachments/tests.py reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/attachments/evolutions/file_attachment_ownership.py Tool: PEP8 Style Checker Processed Files: reviewboard/attachments/tests.py reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/attachments/evolutions/file_attachment_ownership.py -
reviewboard/attachments/evolutions/file_attachment_ownership.py (Diff revision 2) Col: 80 E501 line too long (95 > 79 characters)
RV
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+25 -1) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/attachments/tests.py reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/attachments/evolutions/file_attachment_ownership.py Tool: Pyflakes Processed Files: reviewboard/attachments/tests.py reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/attachments/evolutions/file_attachment_ownership.py
-
-
reviewboard/attachments/evolutions/file_attachment_ownership.py (Diff revision 3) The first line of this file should be
from __future__ import unicode_literals
RV
Summary: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||
Testing Done: |
|
||||||||||||
Commit: |
|
||||||||||||
Diff: |
Revision 4 (+84 -58) |
-
Tool: Pyflakes Processed Files: reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/mimetypes.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/attachments/evolutions/file_attachment_ownership.py Tool: PEP8 Style Checker Processed Files: reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/mimetypes.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/attachments/evolutions/file_attachment_ownership.py -
reviewboard/attachments/evolutions/file_attachment_ownership.py (Diff revision 4) Col: 80 E501 line too long (96 > 79 characters)
-
RV
Change Summary:
Updated base_file_attachment resource to allow for empty path
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+86 -62) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/mimetypes.py reviewboard/attachments/evolutions/file_attachment_ownership.py reviewboard/attachments/forms.py Tool: Pyflakes Processed Files: reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/mimetypes.py reviewboard/attachments/evolutions/file_attachment_ownership.py reviewboard/attachments/forms.py -
reviewboard/attachments/evolutions/file_attachment_ownership.py (Diff revision 5) Col: 80 E501 line too long (96 > 79 characters)
-
RV
Change Summary:
Style changes
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 6 (+88 -62) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/mimetypes.py reviewboard/attachments/evolutions/file_attachment_ownership.py reviewboard/attachments/forms.py Tool: Pyflakes Processed Files: reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/mimetypes.py reviewboard/attachments/evolutions/file_attachment_ownership.py reviewboard/attachments/forms.py
-
I thought we decided that
UploadFileFormwas going to be refactored to have a base class for the common bits, and then subclasses for general file uploading an review request-related uploading? -
reviewboard/attachments/evolutions/file_attachment_ownership.py (Diff revision 6) You'll need to prepend this line to the file, followed by a blank line:
from __future__ import unicode_literalsThis ensures all strings in our codebase are in Unicode format.
-
-
reviewboard/attachments/forms.py (Diff revision 6) Since file and review_request are now optional, they should default to None.
-
-
reviewboard/attachments/forms.py (Diff revision 6) This is referencing
file, since it's None. Doesn't look like this form was tested? -
reviewboard/attachments/forms.py (Diff revision 6) You need 2 blank lines between classes. You removed one of them.
-
-
-
-
-
reviewboard/webapi/resources/base_file_attachment.py (Diff revision 6) Since we're dealing with optional keyword arguments now, can you do:
form.create(file=..., review_request=...)
RV
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 7 (+71 -5) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/base_file_attachment.py reviewboard/attachments/models.py reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/mimetypes.py reviewboard/attachments/evolutions/file_attachment_ownership.py reviewboard/attachments/forms.py
RV
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 8 (+70 -4) |
-
Tool: Pyflakes Processed Files: reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/mimetypes.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/attachments/evolutions/file_attachment_ownership.py Tool: PEP8 Style Checker Processed Files: reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/mimetypes.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/attachments/evolutions/file_attachment_ownership.py -
-
-
-
-
-
-
Tool: PEP8 Style Checker Processed Files: reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/mimetypes.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/attachments/evolutions/file_attachment_ownership.py Tool: Pyflakes Processed Files: reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/mimetypes.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/attachments/evolutions/file_attachment_ownership.py -
-
-
-
-
-
RV
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 10 (+71 -45) |
-
Tool: Pyflakes Processed Files: reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/mimetypes.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/attachments/evolutions/file_attachment_ownership.py Tool: PEP8 Style Checker Processed Files: reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/mimetypes.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/attachments/evolutions/file_attachment_ownership.py
-
This looks good! One small thing from me. I want to make sure everyone else is happy too, but then this should be able to go in.
-
reviewboard/attachments/forms.py (Diff revision 10) Too many blank lines. Should only be one at this level.
RV
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 11 (+70 -45) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/mimetypes.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/attachments/evolutions/file_attachment_ownership.py Tool: Pyflakes Processed Files: reviewboard/attachments/evolutions/__init__.py reviewboard/attachments/mimetypes.py reviewboard/attachments/models.py reviewboard/attachments/forms.py reviewboard/attachments/evolutions/file_attachment_ownership.py
Tool: Pyflakes Processed Files: reviewboard/accounts/models.py reviewboard/attachments/models.py Tool: PEP8 Style Checker Processed Files: reviewboard/accounts/models.py reviewboard/attachments/models.py