[1.7] Allow Review UIs to decide whether they're usable on a case-by-case basis.
Review Request #6007 — Created June 17, 2014 and submitted
ReviewUI
subclaseses can now define ais_enabled_for()
function, which
returns whether it can be enabled for the given user, review request,
and/or file attachment. This allows, for instance, limiting a review UI
based onextra_data
on an object, or based on the given user or
Local Site, or anything else.
Tested this with a file attachment returning True, and then returning False.
Implemented a custom version and tested by file attachment name.
-
-
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 1) Same question here about kwargs vs args.
-
reviewboard/reviews/views.py (Diff revision 1) Does it require using kwargs for these? The variable names seem pretty self explanatory (
is_enabled_for(request.user, review_request. file_attachment)
)
Change Summary:
- Updated the
is_enabled_for
docs to describe the expectations when being called. - Added default arguments for all keyword arguments, indicating they should be used as keyword arguments and not positional.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+33 -4) |

-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/review_request_box.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/review_request_box.html