Add sources for a Windows installer

 






 

 


  Review Request #5998
  —
  Created June 15, 2014 and discarded 

 


















 

  

   Information

  





 
 

  bcran
 









 
 

  RBTools
 









 
 

  release-0.6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
Add code for a Windows installer, built with VS2013 and the WiX Toolset.

 








  


 
 

  
Tested on a clean install of Windows 8.1.

 







 









 





  








 









 






  

 








 














 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    contrib/installer/windows/rbtools.sln
    contrib/installer/windows/favicon.ico
    contrib/installer/windows/rbt.cmd
    contrib/installer/windows/product.wxs
    contrib/installer/windows/README.txt
    contrib/installer/windows/bootstrapper.wixproj
    contrib/installer/windows/bundle.wxs
    contrib/installer/windows/rbtools.wixproj
    contrib/installer/windows/logo.png


    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
  Ignored Files:
    contrib/installer/windows/rbtools.sln
    contrib/installer/windows/favicon.ico
    contrib/installer/windows/rbt.cmd
    contrib/installer/windows/product.wxs
    contrib/installer/windows/README.txt
    contrib/installer/windows/bootstrapper.wixproj
    contrib/installer/windows/bundle.wxs
    contrib/installer/windows/rbtools.wixproj
    contrib/installer/windows/logo.png


    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 BC





   

   

  

 



 















 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    contrib/installer/windows/rbtools.sln
    contrib/installer/windows/favicon.ico
    contrib/installer/windows/rbt.cmd
    contrib/installer/windows/product.wxs
    contrib/installer/windows/README.txt
    contrib/installer/windows/bootstrapper.wixproj
    contrib/installer/windows/bundle.wxs
    contrib/installer/windows/rbtools.wixproj
    contrib/installer/windows/logo.png


    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
  Ignored Files:
    contrib/installer/windows/rbtools.sln
    contrib/installer/windows/favicon.ico
    contrib/installer/windows/rbt.cmd
    contrib/installer/windows/product.wxs
    contrib/installer/windows/README.txt
    contrib/installer/windows/bootstrapper.wixproj
    contrib/installer/windows/bundle.wxs
    contrib/installer/windows/rbtools.wixproj
    contrib/installer/windows/logo.png


    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   





 BC





   

   





  

 



 

  


   

   

    
 
bcran


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ping?
    

    I realise there are probably few Windows developers who could review this, so I'm wondering how I might get this committed?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   





  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Is this missing a rbtools.wxs file?
    

    Can you attach the binary files as attachments?
    

    Also, we're looking to ideally make this consume the RBTools source directory and not need a pre-insatlled copy. We should be able to take a source tree and just build an installer from that. Still learning how this works.. Any suggestions?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      rbtools.wxs is dynamically generated:
      

      <PreBuildEvent>"$(WIX)\bin\heat.exe" dir $(root) -gg -ag -dr INSTALLFOLDER -cg rbgroup -srd -sreg -scom -var var.root -out rbtools.wxs</PreBuildEvent>

      

      (the diff viewer seems to not allow selection of text for copying anymore - is this deliberate?)
      

      I don't know how RBTools is built on Windows, or much about Python packaging in general, so I'm not sure. But it shouldn't be too difficult once you have it built to create new components with the paths to the required files that then get installed into the PortablePython tree.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I don't have the binary files anymore, but I had copied them from the reviewboard repository:
      

        

      • reviewboard\static\rb\images\logo.png
        • 

      • reviewboard\static\rb\images\favicon.ico
        • 

      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      Thanks, Bruce. I've been diving into WiX and have learned a lot more than I ever wanted over the past few days ;)
      

      I have an installer based on your work that we'll be able to more easily automate and keep up-to-date. It's built on top of a minimal install of Portable Python that is then further slimmed down. There's also automation around building all of this.
      

      There will be a review request up in a couple of days.
      

      As for the text selection, it's a bug we've sinced fixed. Just haven't deployed to this server lately.. Need to do that.
      
 
      

      4. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 BC





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Discarded

  
 




 
Change Summary:

 
Discarded in favor of /r/6690/





 


 










  

 









     

    

   

  

  

   
   Loading...