Summary

Add sources for a Windows installer

Review Request #5998 — Created June 15, 2014 and discarded Dec. 31, 2014, 12:32 a.m.

Information

Owner

bcran

Repository

RBTools

Branch

release-0.6.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Add code for a Windows installer, built with VS2013 and the WiX Toolset.

Testing Done

Tested on a clean install of Windows 8.1.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    contrib/installer/windows/rbtools.sln
    contrib/installer/windows/favicon.ico
    contrib/installer/windows/rbt.cmd
    contrib/installer/windows/product.wxs
    contrib/installer/windows/README.txt
    contrib/installer/windows/bootstrapper.wixproj
    contrib/installer/windows/bundle.wxs
    contrib/installer/windows/rbtools.wixproj
    contrib/installer/windows/logo.png

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
  Ignored Files:
    contrib/installer/windows/rbtools.sln
    contrib/installer/windows/favicon.ico
    contrib/installer/windows/rbt.cmd
    contrib/installer/windows/product.wxs
    contrib/installer/windows/README.txt
    contrib/installer/windows/bootstrapper.wixproj
    contrib/installer/windows/bundle.wxs
    contrib/installer/windows/rbtools.wixproj
    contrib/installer/windows/logo.png

Change Summary:

Fix some whitespace issues.

Diff:

Revision 2 (+215)

Show changes

	contrib/installer/windows/README.txt
	contrib/installer/windows/bootstrapper.wixproj
	contrib/installer/windows/bundle.wxs
	contrib/installer/windows/favicon.ico
	contrib/installer/windows/logo.png
	contrib/installer/windows/product.wxs
	contrib/installer/windows/rbt.cmd
	contrib/installer/windows/rbtools.sln
	1 more

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    contrib/installer/windows/rbtools.sln
    contrib/installer/windows/favicon.ico
    contrib/installer/windows/rbt.cmd
    contrib/installer/windows/product.wxs
    contrib/installer/windows/README.txt
    contrib/installer/windows/bootstrapper.wixproj
    contrib/installer/windows/bundle.wxs
    contrib/installer/windows/rbtools.wixproj
    contrib/installer/windows/logo.png

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
  Ignored Files:
    contrib/installer/windows/rbtools.sln
    contrib/installer/windows/favicon.ico
    contrib/installer/windows/rbt.cmd
    contrib/installer/windows/product.wxs
    contrib/installer/windows/README.txt
    contrib/installer/windows/bootstrapper.wixproj
    contrib/installer/windows/bundle.wxs
    contrib/installer/windows/rbtools.wixproj
    contrib/installer/windows/logo.png

Ping?

I realise there are probably few Windows developers who could review this, so I'm wondering how I might get this committed?

Is this missing a rbtools.wxs file?

Can you attach the binary files as attachments?

Also, we're looking to ideally make this consume the RBTools source directory and not need a pre-insatlled copy. We should be able to take a source tree and just build an installer from that. Still learning how this works.. Any suggestions?

bcran Dec. 10, 2014, 10:45 p.m.

rbtools.wxs is dynamically generated:
<PreBuildEvent>"$(WIX)\bin\heat.exe" dir $(root) -gg -ag -dr INSTALLFOLDER -cg rbgroup -srd -sreg -scom -var var.root -out rbtools.wxs</PreBuildEvent>

(the diff viewer seems to not allow selection of text for copying anymore - is this deliberate?)
I don't know how RBTools is built on Windows, or much about Python packaging in general, so I'm not sure. But it shouldn't be too difficult once you have it built to create new components with the paths to the required files that then get installed into the PortablePython tree.

bcran Dec. 10, 2014, 10:56 p.m.

I don't have the binary files anymore, but I had copied them from the reviewboard repository:

reviewboard\static\rb\images\logo.png
reviewboard\static\rb\images\favicon.ico

chipx86 Dec. 11, 2014, 3:17 a.m.

Thanks, Bruce. I've been diving into WiX and have learned a lot more than I ever wanted over the past few days ;)

I have an installer based on your work that we'll be able to more easily automate and keep up-to-date. It's built on top of a minimal install of Portable Python that is then further slimmed down. There's also automation around building all of this.

There will be a review request up in a couple of days.

As for the text selection, it's a bug we've sinced fixed. Just haven't deployed to this server lately.. Need to do that.

Status:: Discarded
Change Summary:: Discarded in favor of /r/6690/