Fix config forms item action and spinner styles in Firefox.

Review Request #5996 — Created June 15, 2014 and submitted

Information

Djblets
master
4043d86...

Reviewers

Firefox didn't display the item actions very well. They were being
wrapped to the following line, due to a combination of float: right
and white-space: nowrap (ironically).

To fix this, we now put all the action elements in a new <span> that's
floated right and placed as the first element in the item. This gives us
the look we want across all browsers.

The spinner is also now properly vertically aligned, and placed right
before any actions (if there are any).

Tested with multiple actions and with a spinner on Chrome and Firefox.

reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        djblets/static/djblets/js/configForms/views/listItemView.js
        djblets/static/djblets/css/config-forms.less
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      Ignored Files:
        djblets/static/djblets/js/configForms/views/listItemView.js
        djblets/static/djblets/css/config-forms.less
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (2246feb)
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.8.x (2246feb)
Loading...