This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: djblets/static/djblets/js/jquery.gravy.inlineEditor.js
Fix issue with links in description/testing done.
Review Request #5985 — Created June 12, 2014 and submitted
When clicking a link inside the element, stop propagation of the click
event so that the link works like normal.
Also tighten up the code is no longer necessary in the mouseup event
because the click handles the same thing.
Tested on my mac in Chrome, Firefox, and Safari (sorry I don't have any IE handy to test with):
- Clicking a link opens in a new tab. -- It no longer opens the editor either if you have permission to edit.
- Clicking and dragging, mouseup on the link selects the text, doesn't open the editor
- Clicking anywhere else still opens the editor.
This is a review from Review Bot. Tool: Pyflakes Processed Files: Ignored Files: djblets/static/djblets/js/jquery.gravy.inlineEditor.js