Fix fetching GitHub branch names containing slashes.

Review Request #5983 — Created June 11, 2014 and submitted

Information

Review Board
release-2.0.x
ae60794...

Reviewers

Git branches can contain slashes, but our GitHub support was stripping
them off. We now support showing the entire branch name, slashes
included, by stripping off the leading 'refs/heads/' instead of
splitting on '/' and getting the last component.

The new additions to the unit test failed before this, but passed after.

Description From Last Updated

NEVER mix tabs and spaces! -- I've found it accidentally by poking around

SQ sq6jnx
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/hostingsvcs/tests.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/hostingsvcs/tests.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (cfbc7d6)
SQ
  1. 
      
  2. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     
    Show all issues

    NEVER mix tabs and spaces!

    -- I've found it accidentally by poking around

    1. By the way I believe there is something wrong with your Review Bot -- mixed tabs & spaces should be found by it

    2. There are no mixed tabs or spaces. That line is showing that the contents indented 4 spaces.

  3. 
      
Loading...