Summary

Fix fetching GitHub branch names containing slashes.

Review Request #5983 — Created June 11, 2014 and submitted June 12, 2014, 1:27 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

ae60794...

Reviewers

Groups

reviewboard

People

Description

Git branches can contain slashes, but our GitHub support was stripping
them off. We now support showing the entire branch name, slashes
included, by stripping off the leading 'refs/heads/' instead of
splitting on '/' and getting the last component.

Testing Done

The new additions to the unit test failed before this, but passed after.

Issues

Description	From	Last Updated
NEVER mix tabs and spaces! -- I've found it accidentally by poking around	SQ sq6jnx	June 26, 2014, 11:46 a.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/hostingsvcs/github.py
    reviewboard/hostingsvcs/tests.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/hostingsvcs/github.py
    reviewboard/hostingsvcs/tests.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (cfbc7d6)

reviewboard/hostingsvcs/github.py (Diff revision 1)

The issue has been dropped. Show all issues

NEVER mix tabs and spaces!

-- I've found it accidentally by poking around

sq6jnx June 26, 2014, 9:13 a.m.

By the way I believe there is something wrong with your Review Bot -- mixed tabs & spaces should be found by it

chipx86 June 26, 2014, 11:46 a.m.

There are no mixed tabs or spaces. That line is showing that the contents indented 4 spaces.