Centralize get_commits() in the SVN backends.
Review Request #5979 — Created June 11, 2014 and submitted
Now that we have a standardized
get_log()
we can call, we no longer need
separateget_commits()
functions in each backend.This change promotes
get_commits()
toSVNTool
, making use of the new
get_log()
, and providing results in a consistent way.
Unit tests for both backends pass.
Description | From | Last Updated |
---|---|---|
Can we define a constant for the limit, so we don't have 31 in two places? I admit fault on … |
david |
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/scmtools/svn/subvertpy.py reviewboard/scmtools/svn/pysvn.py reviewboard/scmtools/svn/__init__.py reviewboard/scmtools/svn/base.py Ignored Files:
- Change Summary:
-
- Updated for changes to
get_log()
. - Added a constant for the commit limit.
- Updated for changes to
- Commit:
-
0c4ea594d3fc70899d671987f7828c1faa11b24d0a1dfd25fb598cb061fe706cf6d2f16cc2c50488
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/svn/subvertpy.py reviewboard/scmtools/svn/pysvn.py reviewboard/scmtools/svn/__init__.py reviewboard/scmtools/svn/base.py Ignored Files: