Centralize get_commits() in the SVN backends.

Review Request #5979 — Created June 11, 2014 and submitted

Information

Review Board
release-2.0.x
0a1dfd2...

Reviewers

Now that we have a standardized get_log() we can call, we no longer need
separate get_commits() functions in each backend.

This change promotes get_commits() to SVNTool, making use of the new
get_log(), and providing results in a consistent way.

Unit tests for both backends pass.

Description From Last Updated

Can we define a constant for the limit, so we don't have 31 in two places? I admit fault on …

daviddavid
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/pysvn.py
        reviewboard/scmtools/svn/__init__.py
        reviewboard/scmtools/svn/base.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/pysvn.py
        reviewboard/scmtools/svn/__init__.py
        reviewboard/scmtools/svn/base.py
      Ignored Files:
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/scmtools/svn/__init__.py (Diff revision 1)
     
     
    Show all issues

    Can we define a constant for the limit, so we don't have 31 in two places?

    I admit fault on this one.

  3. 
      
chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/pysvn.py
        reviewboard/scmtools/svn/__init__.py
        reviewboard/scmtools/svn/base.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/pysvn.py
        reviewboard/scmtools/svn/__init__.py
        reviewboard/scmtools/svn/base.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (1ba8d49)