Summary

Centralize get_commits() in the SVN backends.

Review Request #5979 — Created June 11, 2014 and submitted June 11, 2014, 5:55 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

~~5978~~

Commit

0a1dfd2...

Reviewers

Groups

reviewboard

People

Description

Now that we have a standardized get_log() we can call, we no longer need

separate get_commits() functions in each backend.
This change promotes get_commits() to SVNTool, making use of the new

get_log(), and providing results in a consistent way.

Testing Done

Unit tests for both backends pass.

Issues

Description	From	Last Updated
Can we define a constant for the limit, so we don't have 31 in two places? I admit fault on …	david	June 11, 2014, 5:48 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/scmtools/svn/subvertpy.py
    reviewboard/scmtools/svn/pysvn.py
    reviewboard/scmtools/svn/__init__.py
    reviewboard/scmtools/svn/base.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/scmtools/svn/subvertpy.py
    reviewboard/scmtools/svn/pysvn.py
    reviewboard/scmtools/svn/__init__.py
    reviewboard/scmtools/svn/base.py
  Ignored Files:

reviewboard/scmtools/svn/__init__.py (Diff revision 1)

The issue has been resolved. Show all issues

Can we define a constant for the limit, so we don't have 31 in two places?

I admit fault on this one.

Change Summary:


Updated for changes to get_log().
Added a constant for the commit limit.

Commit:

0c4ea594d3fc70899d671987f7828c1faa11b24d

0a1dfd25fb598cb061fe706cf6d2f16cc2c50488

Diff:

Revision 2 (+36 -61)

Show changes

	reviewboard/scmtools/svn/__init__.py
	reviewboard/scmtools/svn/base.py
	reviewboard/scmtools/svn/pysvn.py
	reviewboard/scmtools/svn/subvertpy.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/scmtools/svn/subvertpy.py
    reviewboard/scmtools/svn/pysvn.py
    reviewboard/scmtools/svn/__init__.py
    reviewboard/scmtools/svn/base.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/scmtools/svn/subvertpy.py
    reviewboard/scmtools/svn/pysvn.py
    reviewboard/scmtools/svn/__init__.py
    reviewboard/scmtools/svn/base.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (1ba8d49)