Add a consistent function in the SVN backends for getting history logs.

Review Request #5978 — Created June 11, 2014 and submitted

chipx86
Review Board
release-2.0.x
5979
d819e8f...
reviewboard

PySVN and Subvertpy had very different ways of getting history logs from
a repository. Both had functions that accepted paths and revision
ranges, but they had different defaults for these parameters and
represented the results in different ways.

This adds a get_log() function for the SVN client backends that return
entries in consistent ways. It'll soon be used to centralize some of the
logic that is currently duplicated between the backends.

Made use of these in an upcoming change. This particular change isn't unit tested,
but the changes making use of this data are.

Description From Last Updated

strict_node_history isn't a very self-explanatory term. Maybe something like ignore_before_branch?

daviddavid
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/pysvn.py
        reviewboard/scmtools/svn/base.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/pysvn.py
        reviewboard/scmtools/svn/base.py
      Ignored Files:
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/scmtools/svn/base.py (Diff revision 1)
     
     

    strict_node_history isn't a very self-explanatory term. Maybe something like ignore_before_branch?

    1. I can change it. I was trying to keep to the terminology that libsvn, subvertpy, and pysvn all use, though, which is why I doc'd it.

    2. I think I'd prefer that our APIs used something that's understandable without knowledge of libsvn, and document that they have a funny name for it.

  3. 
      
chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/pysvn.py
        reviewboard/scmtools/svn/base.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/pysvn.py
        reviewboard/scmtools/svn/base.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (63eba2f)
Loading...