Summary

Add a consistent function in the SVN backends for getting history logs.

Review Request #5978 — Created June 11, 2014 and submitted June 11, 2014, 5:54 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Blocks

5979

Commit

d819e8f...

Reviewers

Groups

reviewboard

People

Description

PySVN and Subvertpy had very different ways of getting history logs from

a repository. Both had functions that accepted paths and revision

ranges, but they had different defaults for these parameters and

represented the results in different ways.
This adds a get_log() function for the SVN client backends that return

entries in consistent ways. It'll soon be used to centralize some of the

logic that is currently duplicated between the backends.

Testing Done

Made use of these in an upcoming change. This particular change isn't unit tested,
but the changes making use of this data are.

Issues

Description	From	Last Updated
strict_node_history isn't a very self-explanatory term. Maybe something like ignore_before_branch?	david	June 11, 2014, 5:43 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/scmtools/svn/subvertpy.py
    reviewboard/scmtools/svn/pysvn.py
    reviewboard/scmtools/svn/base.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/scmtools/svn/subvertpy.py
    reviewboard/scmtools/svn/pysvn.py
    reviewboard/scmtools/svn/base.py
  Ignored Files:

reviewboard/scmtools/svn/base.py (Diff revision 1)

The issue has been resolved. Show all issues

strict_node_history isn't a very self-explanatory term. Maybe something like ignore_before_branch?

chipx86 June 11, 2014, 4:44 p.m.

I can change it. I was trying to keep to the terminology that libsvn, subvertpy, and pysvn all use, though, which is why I doc'd it.

david June 11, 2014, 4:50 p.m.

I think I'd prefer that our APIs used something that's understandable without knowledge of libsvn, and document that they have a funny name for it.

Change Summary:


Normalized paths in get_log().
Reanmed strict_node_history to limit_to_path.

Commit:

4ce81076c619e7a8f54c39e69b0b5dfa37bd8c1f

d819e8fb6d7607cb1cd631a999075b71d8a47bcd

Diff:

Revision 2 (+105 -1)

Show changes

	reviewboard/scmtools/svn/base.py
	reviewboard/scmtools/svn/pysvn.py
	reviewboard/scmtools/svn/subvertpy.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/scmtools/svn/subvertpy.py
    reviewboard/scmtools/svn/pysvn.py
    reviewboard/scmtools/svn/base.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/scmtools/svn/subvertpy.py
    reviewboard/scmtools/svn/pysvn.py
    reviewboard/scmtools/svn/base.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (63eba2f)