Summary

Allow user-customization of the default SVN backend.

Review Request #5970 — Created June 10, 2014 and submitted June 11, 2014, 4 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

10e673b...

Reviewers

Groups

reviewboard

People

Description

Users may end up having both PySVN and Subvertpy installed on the same
system. A previous change had SVNTool favor PySVN over Subvertpy, but
it's useful to be able to specify which one specifically should be used
(especially for development and testing).

The list of possible backends is now specified in
settings.SVNTOOL_BACKENDS. It can be overridden to choose a different
backend (even a custom one, in theory).

This will also form the basis of new multi-backend unit tests.

Testing Done

Tested swapping the backends, with some logging to see which client was
used. The unit tests ran with the custom backend.

Tested emptying the list, which resulted in SVNTool being unusable due to
missing dependencies (same as if neither backend's dependencies were installed).

Tested setting the list to a non-existent module.

Tested setting the list to an actual module that was not a SVNTool backend

Issues

Description	From	Last Updated
Col: 13 E129 visually indented line with same indent as next logical line	reviewbot	June 10, 2014, 6:34 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	June 10, 2014, 6:33 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	June 10, 2014, 6:33 p.m.
'PIPELINE_JS' imported but unused	reviewbot	June 10, 2014, 6:33 p.m.
undefined name 'has_svn_backend'	reviewbot	June 10, 2014, 7:40 p.m.
undefined name 'Client'	reviewbot	June 10, 2014, 7:40 p.m.
Col: 17 E129 visually indented line with same indent as next logical line	reviewbot	June 10, 2014, 7:40 p.m.
'settings' imported but unused	reviewbot	June 10, 2014, 7:40 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	June 10, 2014, 7:39 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	June 10, 2014, 7:39 p.m.
'PIPELINE_JS' imported but unused	reviewbot	June 10, 2014, 7:39 p.m.
undefined name 'has_svn_backend'	reviewbot	June 10, 2014, 7:42 p.m.
undefined name 'Client'	reviewbot	June 10, 2014, 7:42 p.m.
Col: 17 E129 visually indented line with same indent as next logical line	reviewbot	June 10, 2014, 7:42 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	June 10, 2014, 7:42 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	June 10, 2014, 7:42 p.m.
'PIPELINE_JS' imported but unused	reviewbot	June 10, 2014, 7:42 p.m.
Col: 17 E129 visually indented line with same indent as next logical line	reviewbot	June 10, 2014, 7:42 p.m.
Can we log which backend we ended up using?	david	June 11, 2014, 3:53 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	June 10, 2014, 7:42 p.m.
'PIPELINE_JS' imported but unused	reviewbot	June 10, 2014, 7:42 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	June 10, 2014, 7:42 p.m.
Col: 17 E129 visually indented line with same indent as next logical line	reviewbot	June 11, 2014, 3:55 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	June 11, 2014, 3:54 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	June 11, 2014, 3:54 p.m.
'PIPELINE_JS' imported but unused	reviewbot	June 11, 2014, 3:54 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/settings.py
    reviewboard/scmtools/svn/__init__.py
  Ignored Files:

reviewboard/scmtools/svn/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 13
 E129 visually indented line with same indent as next logical line
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/settings.py
    reviewboard/scmtools/svn/__init__.py
  Ignored Files:

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Actually, ignore this for now. Going to make some changes.

Change Summary:

Moved the logic into a function, so that unit tests can recalculate the backend.

Commit:

-	54a0c485b5a943d61ee0c0f9dedadf7424254a39
+	bae57f99a31924de58e3f84578f9cc35fde5b7ea

Diff:

Revision 2 (+56 -5)

Show changes

	reviewboard/settings.py
	reviewboard/scmtools/tests.py
	reviewboard/scmtools/svn/__init__.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/settings.py
    reviewboard/scmtools/svn/__init__.py
  Ignored Files:

reviewboard/scmtools/svn/__init__.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 17
 E129 visually indented line with same indent as next logical line
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/settings.py
    reviewboard/scmtools/svn/__init__.py
  Ignored Files:

reviewboard/scmtools/svn/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'has_svn_backend'
```
reviewboard/scmtools/svn/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'Client'
```
reviewboard/scmtools/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 'settings' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Change Summary:

Removed an import that shouldn't have been in this change.

Commit:

-	bae57f99a31924de58e3f84578f9cc35fde5b7ea
+	ae3c05f0e923d9cd45ae422833a91838006fba5d

Diff:

Revision 3 (+55 -5)

Show changes

	reviewboard/settings.py
	reviewboard/scmtools/svn/__init__.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/settings.py
    reviewboard/scmtools/svn/__init__.py
  Ignored Files:

reviewboard/scmtools/svn/__init__.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 17
 E129 visually indented line with same indent as next logical line
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/settings.py
    reviewboard/scmtools/svn/__init__.py
  Ignored Files:

reviewboard/scmtools/svn/__init__.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 undefined name 'has_svn_backend'
```
reviewboard/scmtools/svn/__init__.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 undefined name 'Client'
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Change Summary:

Set some defaults for Client and has_svn_backend, so that Pyflakes won't complain.

Commit:

-	ae3c05f0e923d9cd45ae422833a91838006fba5d
+	053a01f23ecf252729f0e05531f5158b20555820

Diff:

Revision 4 (+59 -4)

Show changes

	reviewboard/settings.py
	reviewboard/scmtools/svn/__init__.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/settings.py
    reviewboard/scmtools/svn/__init__.py
  Ignored Files:

reviewboard/scmtools/svn/__init__.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 17
 E129 visually indented line with same indent as next logical line
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/settings.py
    reviewboard/scmtools/svn/__init__.py
  Ignored Files:

reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```

reviewboard/scmtools/svn/__init__.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Can we log which backend we ended up using?
```

Change Summary:

Log the SVN backend that's being used.

Commit:

-	053a01f23ecf252729f0e05531f5158b20555820
+	10e673b60a0c69e978ccb755145a182e40dafb32

Diff:

Revision 5 (+60 -4)

Show changes

	reviewboard/settings.py
	reviewboard/scmtools/svn/__init__.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/settings.py
    reviewboard/scmtools/svn/__init__.py
  Ignored Files:

reviewboard/scmtools/svn/__init__.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 17
 E129 visually indented line with same indent as next logical line
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/settings.py
    reviewboard/scmtools/svn/__init__.py
  Ignored Files:

reviewboard/settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (256b2b6)

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 2)