Allow user-customization of the default SVN backend.
Review Request #5970 — Created June 10, 2014 and submitted
Users may end up having both PySVN and Subvertpy installed on the same
system. A previous change had SVNTool favor PySVN over Subvertpy, but
it's useful to be able to specify which one specifically should be used
(especially for development and testing).The list of possible backends is now specified in
settings.SVNTOOL_BACKENDS
. It can be overridden to choose a different
backend (even a custom one, in theory).This will also form the basis of new multi-backend unit tests.
Tested swapping the backends, with some logging to see which client was
used. The unit tests ran with the custom backend.Tested emptying the list, which resulted in SVNTool being unusable due to
missing dependencies (same as if neither backend's dependencies were installed).Tested setting the list to a non-existent module.
Tested setting the list to an actual module that was not a SVNTool backend
Description | From | Last Updated |
---|---|---|
Col: 13 E129 visually indented line with same indent as next logical line |
reviewbot | |
'from settings_local import *' used; unable to detect undefined names |
reviewbot | |
'PIPELINE_CSS' imported but unused |
reviewbot | |
'PIPELINE_JS' imported but unused |
reviewbot | |
undefined name 'has_svn_backend' |
reviewbot | |
undefined name 'Client' |
reviewbot | |
Col: 17 E129 visually indented line with same indent as next logical line |
reviewbot | |
'settings' imported but unused |
reviewbot | |
'from settings_local import *' used; unable to detect undefined names |
reviewbot | |
'PIPELINE_CSS' imported but unused |
reviewbot | |
'PIPELINE_JS' imported but unused |
reviewbot | |
undefined name 'has_svn_backend' |
reviewbot | |
undefined name 'Client' |
reviewbot | |
Col: 17 E129 visually indented line with same indent as next logical line |
reviewbot | |
'from settings_local import *' used; unable to detect undefined names |
reviewbot | |
'PIPELINE_CSS' imported but unused |
reviewbot | |
'PIPELINE_JS' imported but unused |
reviewbot | |
Col: 17 E129 visually indented line with same indent as next logical line |
reviewbot | |
Can we log which backend we ended up using? |
david | |
'from settings_local import *' used; unable to detect undefined names |
reviewbot | |
'PIPELINE_JS' imported but unused |
reviewbot | |
'PIPELINE_CSS' imported but unused |
reviewbot | |
Col: 17 E129 visually indented line with same indent as next logical line |
reviewbot | |
'from settings_local import *' used; unable to detect undefined names |
reviewbot | |
'PIPELINE_CSS' imported but unused |
reviewbot | |
'PIPELINE_JS' imported but unused |
reviewbot |
- Change Summary:
-
Moved the logic into a function, so that unit tests can recalculate the backend.
- Commit:
-
54a0c485b5a943d61ee0c0f9dedadf7424254a39bae57f99a31924de58e3f84578f9cc35fde5b7ea
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/scmtools/tests.py reviewboard/settings.py reviewboard/scmtools/svn/__init__.py Ignored Files:
-
-
-
-
-
-
- Change Summary:
-
Removed an import that shouldn't have been in this change.
- Commit:
-
bae57f99a31924de58e3f84578f9cc35fde5b7eaae3c05f0e923d9cd45ae422833a91838006fba5d
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/settings.py reviewboard/scmtools/svn/__init__.py Ignored Files:
-
-
-
-
-
- Change Summary:
-
Set some defaults for
Client
andhas_svn_backend
, so that Pyflakes won't complain. - Commit:
-
ae3c05f0e923d9cd45ae422833a91838006fba5d053a01f23ecf252729f0e05531f5158b20555820
- Change Summary:
-
Log the SVN backend that's being used.
- Commit:
-
053a01f23ecf252729f0e05531f5158b2055582010e673b60a0c69e978ccb755145a182e40dafb32