-
-
rbtools/utils/repository.py (Diff revision 1) Col: 5 E129 visually indented line with same indent as next logical line
Fix compatibility issues with older versions of Review Board.
Review Request #5963 — Created June 9, 2014 and submitted
Versions prior to 1.7.8 didn't have a 'url' field, causing
the 'absolute_url' property to fail at generated a suitable URL. We now
have a custom 'url' property on ReviewRequestResource that provides a
suitable default, just like 'absolute_url' does.Likewise, versions of Review Board prior to 1.7.19 didn't have a
'mirror_path' field on the Repository resource, which broke a lookup. We
now conditionally get the 'mirror_path' instead of assuming it's there.
This is done instead of providing a custom property, in order to prevent
the resource from being misleading (since we can't generate any sane
default there).
New unit tests pass.
| Description | From | Last Updated |
|---|---|---|
|
Col: 5 E129 visually indented line with same indent as next logical line |
 reviewbot
|
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/api/tests.py rbtools/utils/repository.py rbtools/api/resource.py Ignored Files: