Prioritize the repository name over URL when posting changes.

Review Request #5960 — Created June 9, 2014 and submitted

Information

RBTools
master
5ee0ac4...

Reviewers

rbt post was assuming that the repository URL provided should take
precedence over the repository name. The problem is that Subversion can
be given a repository URL that it can use for communicating with the
repository, but that URL isn't necessarily the one we want for lookup.

The Subversion issue should be fixed separately, but it's safe to say
that the repository name is a better option if provided. We now use that
over the URL if we have it.

Posted a change, providing both --repository and --repository-url. It
matched against the name.

reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        rbtools/commands/post.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        rbtools/commands/post.py
      Ignored Files:
    
    
  2. 
      
david
  1. I think this fixes bug 3277.

  2. 
      
chipx86
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.6.x (9bb587d)
Loading...