• 
      

    Switch the default SVN backend to PySVN and require a newer Subvertpy.

    Review Request #5957 — Created June 9, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    2635a01...

    Reviewers

    While Subvertpy is easier to build, it's less complete than PySVN, and
    has been the source of several bugs. Some users who have tried switching
    to PySVN from Subvertpy have had issues due to a version of Subvertpy
    remaining on the system.

    We now default to PySVN as the backend if it's installed. It's
    better-tested and likely to be more compatible.

    For Subvertpy support to work, a minimum version of 0.9.1 must be
    installed, since older versions have caused errors we don't want to deal
    with.

    I also renamed 'imported_dependency' to 'has_svn_backend', which is a
    bit more clear and less likely to result in conflicts.

    Tested that PySVN was being used by default here.

    Tested the version comparison with my installed version, and with various other
    versions by hand.

    Unit tests pass.

    Description From Last Updated

    redefinition of unused 'Client' from line 19

    reviewbotreviewbot
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          reviewboard/scmtools/svn/subvertpy.py
          reviewboard/scmtools/svn/__init__.py
          reviewboard/scmtools/svn/pysvn.py
        Ignored Files:
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          reviewboard/scmtools/svn/subvertpy.py
          reviewboard/scmtools/svn/__init__.py
          reviewboard/scmtools/svn/pysvn.py
        Ignored Files:
      
      
    2. reviewboard/scmtools/svn/__init__.py (Diff revision 1)
       
       
      Show all issues
       redefinition of unused 'Client' from line 19
      
    3. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (e2f4855)