Summary

Fix handling of string types for perforce changeset descriptions.

Review Request #5953 — Created June 7, 2014 and submitted June 8, 2014, 1:28 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

3407

Depends On

Commit

19c4e7b...

Reviewers

Groups

reviewboard

People

Description

We get data out of p4python as strs, but we weren't treating them as such.
This change adds some logic to decode changesets before processing them, which
should improve the situation.

Testing Done

Ran unit tests.

Expand All
Collapse All

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/perforce.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/perforce.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (5408b54)