Allow sending a test e-mail from the e-mail settings form.
Review Request #5952 — Created June 7, 2014 and submitted
When changing the server settings for how to send e-mail, it's nice to give
people the option to test it (so they don't have to create a fake review
request and jump through a bunch of hoops). This change adds a new check-box
that allows users to trigger such an email after the form is saved.This doesn't cover 100% of the things that can go wrong with sending e-mails
(such as random SPF/DKIM failures or mail servers that don't like the
Sender/From distinction), but it should be good enough to verify that you typed
your SMTP credentials correctly.This also organizes the e-mail settings into three sections.
Set my e-mail backend to console and saved the form with this check-box set.
Saw that it "sent" an e-mail from the correct Sender (noreply) to my user's
configured e-mail address.
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/admin/forms.py Ignored Files:
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+50) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/admin/forms.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/admin/forms.py Ignored Files:
-
-
reviewboard/admin/forms.py (Diff revision 2) "myself" should probably be "yourself" here. None of our help text reads as the user.
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/admin/forms.py Ignored Files: