• 
      

    Allow sending a test e-mail from the e-mail settings form.

    Review Request #5952 — Created June 7, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    c9dd052...

    Reviewers

    When changing the server settings for how to send e-mail, it's nice to give
    people the option to test it (so they don't have to create a fake review
    request and jump through a bunch of hoops). This change adds a new check-box
    that allows users to trigger such an email after the form is saved.

    This doesn't cover 100% of the things that can go wrong with sending e-mails
    (such as random SPF/DKIM failures or mail servers that don't like the
    Sender/From distinction), but it should be good enough to verify that you typed
    your SMTP credentials correctly.

    This also organizes the e-mail settings into three sections.

    Set my e-mail backend to console and saved the form with this check-box set.
    Saw that it "sent" an e-mail from the correct Sender (noreply) to my user's
    configured e-mail address.

    Description From Last Updated

    Col: 13 E303 too many blank lines (2)

    reviewbotreviewbot

    "myself" should probably be "yourself" here. None of our help text reads as the user.

    chipx86chipx86
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          reviewboard/admin/forms.py
        Ignored Files:
      
      
    2. reviewboard/admin/forms.py (Diff revision 1)
       
       
      Show all issues
      Col: 13
       E303 too many blank lines (2)
      
    3. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          reviewboard/admin/forms.py
        Ignored Files:
      
      
    2. 
        
    david
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          reviewboard/admin/forms.py
        Ignored Files:
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          reviewboard/admin/forms.py
        Ignored Files:
      
      
    2. 
        
    chipx86
    1. 
        
    2. reviewboard/admin/forms.py (Diff revision 2)
       
       
      Show all issues

      "myself" should probably be "yourself" here. None of our help text reads as the user.

    3. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (748cdb1)