Fix word wrapping in review request details fields.
Review Request #5951 — Created June 7, 2014 and submitted
Long strings in the review request details fields (on the right-hand side of
the fields) would increase the width of the entire table, eventually
overlapping the main fields in a very ugly way. This change adds a max-width to
the field spans, and specifies a word-wrap to force browsers to insert line
breaks in the middle of words in the case that it can't break at a natural
place.
- Set a branch that was just one long unbroken string of characters and saw it
wrap at the width of the details pane. - Checked that a bunch of comma-separated bug numbers still wrapped at an ideal
place in the text.
Description | From | Last Updated |
---|---|---|
Where does 12em come from? Does anything else use it? We should make this a constant somewhere. |
chipx86 | |
Can you add a comment saying that any changes to this need to be reflected in _resizeLayout in reviewRequestEditorView.js? |
chipx86 | |
Can we stick with: /* * this multi-line * comment format? */ |
chipx86 | |
We should fetch the tbody first, and do further filters from that. |
chipx86 | |
How does this look if the value is wrapped to the following line? |
chipx86 |
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: Ignored Files: reviewboard/static/rb/css/reviews.less
-
-
reviewboard/static/rb/css/reviews.less (Diff revision 1) Where does 12em come from? Does anything else use it?
We should make this a constant somewhere.
Change Summary:
Switch to computing max-width on the client side.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+18 -9) |
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/css/reviews.less reviewboard/static/rb/js/views/reviewRequestEditorView.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/css/reviews.less reviewboard/static/rb/js/views/reviewRequestEditorView.js
-
-
reviewboard/static/rb/css/reviews.less (Diff revision 2) Can you add a comment saying that any changes to this need to be reflected in
_resizeLayout
in reviewRequestEditorView.js? -
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 2) We should fetch the tbody first, and do further filters from that.
-
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 2) How does this look if the value is wrapped to the following line?
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+21 -9) |
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/css/reviews.less reviewboard/static/rb/js/views/reviewRequestEditorView.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/css/reviews.less reviewboard/static/rb/js/views/reviewRequestEditorView.js
-
-
reviewboard/static/rb/css/reviews.less (Diff revisions 2 - 3) Can we stick with:
/* * this multi-line * comment format? */