-
-
rbtools/clients/__init__.py (Diff revision 1) Col: 13 E129 visually indented line with same indent as next logical line
-
rbtools/clients/__init__.py (Diff revision 1) Col: 17 E129 visually indented line with same indent as next logical line
Handle added and deleted empty files in 'rbt patch'.
Review Request #5938 — Created June 5, 2014 and submitted
| Information | |
|---|---|
| anselina | |
| RBTools | |
| master | |
| 3390 | |
| 43bf8ea... | |
| Reviewers | |
| rbtools | |
Added and deleted empty files were simply ignored when running
rbt patchon
SVN, Mercurial, and Perforce repositories sincepatchdoes not handle empty
files.Now, we do extra processing after running
patchto manually check for and
handle any added or deleted empty files in the patch file. These empty files
are expected to have a diff in the same format as that generated byrbt post.
- Ran unit tests.
- Created several review requests using
rbt poston SVN, Mercurial, and
Perforce repositories with different diffs: no empty files, an added empty
file, a deleted empty file, multiple added and deleted empty files, and
multiple added/deleted empty and non-empty files. Ranrbt patchand
verified that the empty files were added/deleted (viasvn status, etc.).
| Description | From | Last Updated |
|---|---|---|
|
Col: 13 E129 visually indented line with same indent as next logical line |
 reviewbot
|
|
|
rbtools still needs to support Python 2.5, so this should be except IOError, e |
 david
|
|
|
Col: 17 E129 visually indented line with same indent as next logical line |
reviewbot
|
|
|
Here too. |
david
|
|
|
Here too. |
david
|
|
|
Col: 13 E129 visually indented line with same indent as next logical line |
reviewbot
|
|
|
Col: 17 E129 visually indented line with same indent as next logical line |
reviewbot
|
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: rbtools/commands/patch.py rbtools/clients/__init__.py rbtools/clients/mercurial.py rbtools/utils/filesystem.py rbtools/clients/perforce.py rbtools/clients/svn.py Ignored Files:
-
Looks pretty great. Just one small thing in three places.
-
rbtools/clients/__init__.py (Diff revision 1) rbtools still needs to support Python 2.5, so this should be
except IOError, e -
-
Change Summary:
Fix compatibility with Python 2.5.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+194 -3) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/commands/patch.py rbtools/clients/__init__.py rbtools/clients/mercurial.py rbtools/utils/filesystem.py rbtools/clients/perforce.py rbtools/clients/svn.py Ignored Files: -
rbtools/clients/__init__.py (Diff revision 2) Col: 13 E129 visually indented line with same indent as next logical line
-
rbtools/clients/__init__.py (Diff revision 2) Col: 17 E129 visually indented line with same indent as next logical line
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/commands/patch.py rbtools/clients/__init__.py rbtools/clients/mercurial.py rbtools/utils/filesystem.py rbtools/clients/perforce.py rbtools/clients/svn.py Ignored Files: