Summary

Handle added and deleted empty files in 'rbt patch'.

Review Request #5938 — Created June 5, 2014 and submitted June 8, 2014, 4:39 p.m.

Information

Owner

anselina

Repository

RBTools

Branch

master

Bugs

3390

Depends On

Commit

43bf8ea...

Reviewers

Groups

rbtools

People

Description

Added and deleted empty files were simply ignored when running rbt patch on
SVN, Mercurial, and Perforce repositories since patch does not handle empty
files.

Now, we do extra processing after running patch to manually check for and
handle any added or deleted empty files in the patch file. These empty files
are expected to have a diff in the same format as that generated by rbt post.

Testing Done


Ran unit tests.
Created several review requests using rbt post on SVN, Mercurial, and

  Perforce repositories with different diffs: no empty files, an added empty

  file, a deleted empty file, multiple added and deleted empty files, and

  multiple added/deleted empty and non-empty files. Ran rbt patch and

  verified that the empty files were added/deleted (via svn status, etc.).

Issues

Description	From	Last Updated
Col: 13 E129 visually indented line with same indent as next logical line	reviewbot	June 5, 2014, 2:09 p.m.
rbtools still needs to support Python 2.5, so this should be except IOError, e	david	June 8, 2014, 3:28 p.m.
Col: 17 E129 visually indented line with same indent as next logical line	reviewbot	June 5, 2014, 2:09 p.m.
Here too.	david	June 8, 2014, 3:28 p.m.
Here too.	david	June 8, 2014, 3:28 p.m.
Col: 13 E129 visually indented line with same indent as next logical line	reviewbot	June 8, 2014, 3:31 p.m.
Col: 17 E129 visually indented line with same indent as next logical line	reviewbot	June 8, 2014, 3:31 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/commands/patch.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/utils/filesystem.py
    rbtools/clients/perforce.py
    rbtools/clients/svn.py
  Ignored Files:

rbtools/clients/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 13
 E129 visually indented line with same indent as next logical line
```
rbtools/clients/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 17
 E129 visually indented line with same indent as next logical line
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    rbtools/commands/patch.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/utils/filesystem.py
    rbtools/clients/perforce.py
    rbtools/clients/svn.py
  Ignored Files:

Looks pretty great. Just one small thing in three places.

rbtools/clients/__init__.py (Diff revision 1)

The issue has been resolved. Show all issues

rbtools still needs to support Python 2.5, so this should be except IOError, e

rbtools/utils/filesystem.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Here too.
```
rbtools/utils/filesystem.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Here too.
```

Change Summary:

Fix compatibility with Python 2.5.

Commit:

003fe140a90c477afcf19eb52ea0bd96648bd3eb

43bf8ea7840f92a771bc7f3b289bb4d99119e25b

Diff:

Revision 2 (+194 -3)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/mercurial.py
	rbtools/clients/perforce.py
	rbtools/clients/svn.py
	rbtools/commands/patch.py
	rbtools/utils/filesystem.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/commands/patch.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/utils/filesystem.py
    rbtools/clients/perforce.py
    rbtools/clients/svn.py
  Ignored Files:

rbtools/clients/__init__.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 13
 E129 visually indented line with same indent as next logical line
```
rbtools/clients/__init__.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 17
 E129 visually indented line with same indent as next logical line
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    rbtools/commands/patch.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/utils/filesystem.py
    rbtools/clients/perforce.py
    rbtools/clients/svn.py
  Ignored Files:

Status:: Completed
Change Summary:: Pushed to master (48ba9d4)

Status:: Completed
Change Summary:: Pushed to release-0.6.x (48ba9d4)

Ship it!

```
Ship It!
```