Fix reloading of logging settings.

Review Request #5934 — Created June 4, 2014 and submitted

Information

Djblets
release-0.8.x
03fd654...

Reviewers

restart_logging() wasn't properly reloading the logging settings. It
didn't know about all the handlers that were set, meaning the previously
registered ones wouldn't be reloaded. This led to duplicate log messages
with every attempt to reload.

It now unregisters every single log handler before re-adding them.

Restarted logging several times, and only saw one message per log statement.

reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        djblets/log/__init__.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        djblets/log/__init__.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.8.x (708d1b3)
Loading...