Don't error out if receiving an unexpected line in 'svn status'.

 






 

 


  Review Request #5925
  —
  Created June 3, 2014 and submitted 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  RBTools
 









 
 

  release-0.6.x
 









 
 

  
 









 
 

  
 









 
 

  5a2c8f5...
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
When 'svn status', we'd attempt to look for particular data to indicate

whether there's any files scheduled to retain history in the commit. We

assumed there would be a 4th column to check, but this doesn't always

appear to be the case. We now catch any IndexErrors here and ignore

them.

 








  


 
 

  
I wasn't able to reproduce this, but given the traceback from a customer,

this should prevent the failures they saw.

 







 









 





  








 









 






  

 








 














 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/clients/svn.py
  Ignored Files:


    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    rbtools/clients/svn.py
  Ignored Files:


    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




chipx86




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-0.6.x (3132e1c)





 


 










  

 









     

    

   

  

  

   
   Loading...