Check HTTP status codes in the GitHub service for errors.

Review Request #5921 — Created June 2, 2014 and submitted

Information

Review Board
master
cef6726...

Reviewers

Now that we have an http_code field in HostingServiceError, we can
check it instead of the error message text. This should help prevent
problems in the future if strings ever change.

Unit tests pass.

reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/hostingsvcs/github.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/hostingsvcs/github.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to master (673b0a4)