Summary

Check HTTP status codes in the GitHub service for errors.

Review Request #5921 — Created June 2, 2014 and submitted June 2, 2014, 2 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

cef6726...

Reviewers

Groups

reviewboard

People

Description

Now that we have an http_code field in HostingServiceError, we can
check it instead of the error message text. This should help prevent
problems in the future if strings ever change.

Testing Done

Unit tests pass.

Expand All
Collapse All

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/hostingsvcs/github.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/hostingsvcs/github.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (673b0a4)