Summary

Add web API support for querying remote repositories.

Review Request #5917 — Created June 2, 2014 and submitted June 5, 2014, 11:41 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

c17c76e...

Reviewers

Groups

reviewboard

People

Description

This adds a new child resource off the HostingServiceAccount resource
for querying remote repositories.

Since every hosting service works differently, this resource needs to
take different query parameters depending on the hosting service it's
querying. Specifically, the owner-type= and filter-type= values.

Testing Done

Tested this with valid and invalid repositories on GitHub.

Tested different possible values for owner_type and filter_type.

Unit tests pass.

Built docs and saw that they looked correct (though, examples and links
have to be turned off, since we don't have DB-backed state to generate
from).

Issues

Description	From	Last Updated
Should these have any kind of bounds checking?	david	June 2, 2014, 5:28 p.m.
How about s/against/for/?	david	June 2, 2014, 5:29 p.m.
"that service"	david	June 2, 2014, 5:29 p.m.
Get rid of "down"	david	June 2, 2014, 5:36 p.m.
How about putting this into a mixin class, rather than monkey patching it in?	david	June 2, 2014, 5:38 p.m.
Should include a comma after this.	david	June 2, 2014, 5:38 p.m.
This line should have a comma after it.	david	June 2, 2014, 5:38 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/remote_repository.py
    reviewboard/webapi/tests/test_remote_repository.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/hosting_service_account.py
  Ignored Files:
    docs/manual/webapi/2.0/resources/remote-repository-list.rst
    docs/manual/fixtures/initial_data.json
    docs/manual/webapi/2.0/resources/index.rst
    docs/manual/webapi/2.0/resources/remote-repository.rst

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/remote_repository.py
    reviewboard/webapi/tests/test_remote_repository.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/hosting_service_account.py
  Ignored Files:
    docs/manual/webapi/2.0/resources/remote-repository-list.rst
    docs/manual/fixtures/initial_data.json
    docs/manual/webapi/2.0/resources/index.rst
    docs/manual/webapi/2.0/resources/remote-repository.rst

reviewboard/webapi/resources/remote_repository.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should these have any kind of bounds checking?
```
reviewboard/webapi/resources/remote_repository.py (Diff revision 1)
The issue has been resolved. Show all issues
```
How about s/against/for/?
```
reviewboard/webapi/resources/remote_repository.py (Diff revision 1)
The issue has been resolved. Show all issues
```
"that service"
```
reviewboard/webapi/resources/remote_repository.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Get rid of "down"
```

reviewboard/webapi/tests/test_remote_repository.py (Diff revision 1)

The issue has been dropped. Show all issues

How about putting this into a mixin class, rather than monkey patching it in?

chipx86 June 2, 2014, 5:39 p.m.

Can't :(. The way that the existing mixins work actually prevents this from being mixed in. It's annoying. I've had to do this elsewhere as well.

The metaclass is mixing in the base test classes. Those end up taking precedence over any mixins we specify when defining the class.

reviewboard/webapi/tests/test_remote_repository.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should include a comma after this.
```
reviewboard/webapi/tests/test_remote_repository.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This line should have a comma after it.
```

Change Summary:


Improved docs.
Added bounds checking for get_prev_index. (get_next_index has no checking, as we have no guarantee of any reliable counts from the server).
Added trailing commas.

Commit:

-	43ae151a9c01e2ae41ee3acba223e83218f7cf99
+	c17c76ea2101232886ea5632c344f1d8512c9ff0

Diff:

Revision 2 (+423 -2)

Show changes

	docs/manual/fixtures/initial_data.json
	docs/manual/webapi/2.0/resources/index.rst
	docs/manual/webapi/2.0/resources/remote-repository.rst
	docs/manual/webapi/2.0/resources/remote-repository-list.rst
	reviewboard/testing/testcase.py
	reviewboard/webapi/resources/hosting_service_account.py
	reviewboard/webapi/resources/remote_repository.py
	reviewboard/webapi/tests/mimetypes.py
	2 more

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/remote_repository.py
    reviewboard/webapi/tests/test_remote_repository.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/hosting_service_account.py
  Ignored Files:
    docs/manual/webapi/2.0/resources/remote-repository-list.rst
    docs/manual/fixtures/initial_data.json
    docs/manual/webapi/2.0/resources/index.rst
    docs/manual/webapi/2.0/resources/remote-repository.rst

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/remote_repository.py
    reviewboard/webapi/tests/test_remote_repository.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/hosting_service_account.py
  Ignored Files:
    docs/manual/webapi/2.0/resources/remote-repository-list.rst
    docs/manual/fixtures/initial_data.json
    docs/manual/webapi/2.0/resources/index.rst
    docs/manual/webapi/2.0/resources/remote-repository.rst

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (89ba511)